Parameters access key id and secret key about awss3promisified HOT 6 CLOSED

From looking at the code, it seems not. Though changing that would be easy. If you remove the parentheses on the last line, you can pass them as parameters to the initialize function. That means you have to initialize it, though.

//UNTESTED
var awsS3Promisified = {

  initialize: function(AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY) {
  ...


};

module.exports = awsS3Promisified.initialize;   <<<<< like this

You may need to remove the parameters as well, in case there are conflicts.

from awss3promisified.

Great thanks!

from awss3promisified.

Hi @mrn3 - I just made a little update to make this easier. You should now be able to do:

var aws = require('aws-s3-promisified').initialize(AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY);

from awss3promisified.

@alliejanoch I think you have a typo in that example. Shouldn't it be...

var aws = require('aws-s3-promisified').initialize(AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY);

Also, I think what @ssaunders makes sense. It would be a little nicer to not have to explicitly call initialize. This would be a breaking change to the API though.

var aws = require('aws-s3-promisified')(AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY);

from awss3promisified.

@mrn3 - I've released a new version of the library. This will break code that worked with previous versions. You can now initialize like this:

var aws = require('aws-s3-promisified')({
    accessKeyId: AWS_ACCESS_KEY_ID,
    secretAccessKey: AWS_SECRET_ACCESS_KEY
});

from awss3promisified.

Great thanks!

from awss3promisified.