Code Monkey home page Code Monkey logo

Comments (14)

manzinello avatar manzinello commented on June 16, 2024

Interesting suggestion. Maybe I can work on new attributes in MailgoConfig for this!

from mailgo.

yoavaviram avatar yoavaviram commented on June 16, 2024

That would be awesome!

from mailgo.

yoavaviram avatar yoavaviram commented on June 16, 2024

Hi @manzinello , have you made any progress on this one?

from mailgo.

manzinello avatar manzinello commented on June 16, 2024

Hi @yoavaviram, at the moment I am testing a new version of mailgo (0.11.0), that contains already a lot of changes.
After the release i will work on enhancements like this one, absolutely.

from mailgo.

manzinello avatar manzinello commented on June 16, 2024

I've worked on this! There will be the new details attribute in configuration where you will be able to show/hide elements of the details from the modal (cc, bcc, body and subject for emails, msg for tel).
I am working on this (and testing it), you can check it in index.windowconfig.html in examples removing the comment on cc (2bce02b)

from mailgo.

yoavaviram avatar yoavaviram commented on June 16, 2024

Amazing, when do you think it will be released?

from mailgo.

manzinello avatar manzinello commented on June 16, 2024

I will try to release a new mailgo version with these new features within the end of the week!
I will keep you updated about this directly in this issue.

from mailgo.

yoavaviram avatar yoavaviram commented on June 16, 2024

Thanks!

from mailgo.

manzinello avatar manzinello commented on June 16, 2024

Relased mailgo 0.11.2 now with the new details attribute in configuration, here the documentation: https://mailgo.dev/docs/configuration#details.
I close this issue, if there is something else please open a new one!

from mailgo.

yoavaviram avatar yoavaviram commented on June 16, 2024

Amazing!

We're now using mailgo in production (for example when you submit the form at the top of this page. I've also added you to our list of sponsors on our about page.

A few questions and comments:

  1. It seems like the direct render option parses configuration in a different way to the normal initialization. While the 'details' attribute is supported 'dark' is not.
  2. Maybe related to number 1, passing a dictionary with configuration options to the direct renderer had no affect. I had to use window.mailgoConfig option. If this is the intended usage I suggest noting it in the documentation since it was not obvious to me.
  3. It would be great to be able to hide the 'to' field in addition to the others (subject, bcc, cc, body). In my use the user is about to review all of these fields in their email client so no reason to do it twice.

Here is the code that's currently in production: https://github.com/your-digital-rights/yourdigitalrights.org/blob/master/src/components/PersonalInfoForm/index.js

Many thanks!

from mailgo.

manzinello avatar manzinello commented on June 16, 2024

Thank you so much for your comments! I will check it and maybe will open single issues for them. In particular the first 2 seems to be bugs, so I have obviously to check them in deep. If you want to open single issues for them feel free to to it, otherwise I will do it.
Have a great day,

from mailgo.

yoavaviram avatar yoavaviram commented on June 16, 2024

Another issue: clicking on 'copy' only copies the recipient's email address.

from mailgo.

yoavaviram avatar yoavaviram commented on June 16, 2024

Also, the subject line opens up as the "to" address in gmail. This makes the librafry unusable for us in the current state.

from mailgo.

yoavaviram avatar yoavaviram commented on June 16, 2024

I have opened issues for the relevant problems.

from mailgo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.