Code Monkey home page Code Monkey logo

Comments (3)

gustavopch avatar gustavopch commented on July 17, 2024

I think the following solution accounts for the caveat I talked about in the last post:

body:{
	overflow: isOpen ? 'auto' : 'hidden',
	maxHeight: window.innerHeight,
	backgroundColor: 'white',
	...this.props.bodyStyle
}

Not sure how this could impact the rendering performance, but it's working fine in my Moto G 2nd generation.

from react-swipeable-bottom-sheet.

manufont avatar manufont commented on July 17, 2024

I added the property 'scrollOnWindowOverflow' which should do the trick.

from react-swipeable-bottom-sheet.

gustavopch avatar gustavopch commented on July 17, 2024

Awesome!

@manufont I found one more thing. When the main page already has a scrollbar, the bottom sheet gets a second one. As the bottom sheet is covering the whole screen, no interaction with the main page is expected and therefore it shouldn't be scrollable in this situation.

from react-swipeable-bottom-sheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.