Comments (5)
I do not understand why the id is passed anyway.
Doesn't Collection.insert generate a id on its own if not passed? And this should even work if happens both in a client-stub and the server-method?
from mantra-sample-blog-app.
The id of two sides should be the same. If you use the id generated by insert. Probably it's not same as client stub.
from mantra-sample-blog-app.
The id is passed in for latency compensation.
The solution is pretty simple, just need to create a custom check function for uuid, to verify it is correct. This would prevent passing in invalid uuids, and make the latency compensation still work.
something like this:
check(_id, Uuid);
from mantra-sample-blog-app.
FYI, the Meteor.uuid()
call should most likely be replaced by Random.id()
https://github.com/meteor/meteor/tree/master/packages/random
from mantra-sample-blog-app.
Submitted a pr for this fix.
A uuid validator is pretty much a check for a string that is 17 characters -- there really isn't a necessity to check for anything further, as it's all randomized anyways. You can see how this is created with a custom matcher at https://github.com/markoshust/mantra-sample-blog-app/blob/ef35a2fac1eba766eab08959b315c5f4636b38e7/lib/match.js
Then, just import that matcher and run check against it, as so https://github.com/markoshust/mantra-sample-blog-app/blob/0ae9cc607642ca99e76f6f0956a0f07dc60bf800/server/publications/posts.js
I'm not 100% sure this is really needed on the client... most likely just needed on server, but updated client scripts to keep things consistent.
I also updated Meteor.uuid() to Random.id().
from mantra-sample-blog-app.
Related Issues (20)
- MUI leeds to Uncaught Invariant Violation
- storybook fails with unmodified repo, and with meteor 1.3.2.4 HOT 5
- jsdom error on npm test HOT 3
- FlowRouter SSR don't work properly HOT 1
- Git project description demo URL needs updating HOT 1
- Failed to parse SourceMap: http://localhost:3000/packages/5b3...a10.map HOT 2
- Comments on naming variables
- Unable to resolve some modules: lib/collections HOT 3
- broken link at top of https://github.com/mantrajs/mantra-sample-blog-app HOT 1
- why not testing server code with wallaby?
- In container file,Where is the arguments of composer function comes from? HOT 4
- Why fetch in composer? HOT 6
- How to check authenticated routes? HOT 1
- no .meteor.com anymore HOT 1
- Cannot Deploy to Galaxy from Mac (Due to binary NPM modules in dev dependencies) HOT 6
- how to bind some arg to all actions ? HOT 1
- loading component HOT 2
- This fails on my system with storybook (app and tests its ok) HOT 1
- FindOne instead find in post.single publication HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mantra-sample-blog-app.