Code Monkey home page Code Monkey logo

Comments (10)

ynnoj avatar ynnoj commented on July 24, 2024

Hey @griffind. You're right, this is a package dependency to compile the included SCSS for the message themes.

You can install it by running ember install:npm broccoli-sass in your project directory. I should update the README to mention this.

Let me know if you have any further problems.

from ember-cli-notifications.

griffind avatar griffind commented on July 24, 2024

@ynnoj okay just checking. I am still having trouble though, as I have never really used Sass. After installing 'broccoli-sass' I started to get an error at build that 'font-awesome' was already included, so I removed the 'app.import' statements from your index.js. After that, it built, but the messages do not show. Any idea on how to get this running, I am new to this stuff so naturally I have limited experience.

Any help is greatly appreciated.

from ember-cli-notifications.

griffind avatar griffind commented on July 24, 2024

@ynnoj Okay I got the notification to show, but the css is not being applied. Will begin working on that now, if you have any suggestions on how to do that, that would be great.

Thanks again for your patience.

from ember-cli-notifications.

griffind avatar griffind commented on July 24, 2024

@ynnoj So, I tried to hack away at getting the addon to work all night and have yet to get it to do so. It threw an error that I needed to create an app.scss file so I did so. In the app.scss file, I tried to use @import to import the /styles from the addon, and that also did not work. I tried importing the styles in my brocfile.js, I tried using browserify.js to consume the addon with ES6 sytax, and none of this worked either.

I can't help but think that I am missing something that is obvious, but I can't think of what it is.

from ember-cli-notifications.

ynnoj avatar ynnoj commented on July 24, 2024

@griffind The SCSS for the message styles are compiled to vendor.css in your projects dist/assets directory. Is this being compiled correctly?

Your Ember app should include this CSS file by default. Take a look at index.html in your project and see if it's in there.

<link rel="stylesheet" href="assets/vendor.css">

from ember-cli-notifications.

griffind avatar griffind commented on July 24, 2024

@ynnoj It seems like it is compiling to the vendor.css fine. I have shared a git of the problem here: https://github.com/griffind/fixtureTest

Let me know if you can find what is going wrong.

from ember-cli-notifications.

lolmaus avatar lolmaus commented on July 24, 2024

I've ran into the same issue.

Selectors containing interopolation, e. g. .#{$notification-css-prefix} are rendered into vendor.css as .false, .false-icon, .false-content, etc.

from ember-cli-notifications.

lolmaus avatar lolmaus commented on July 24, 2024

Okay, the problem was that the variable's value was unquoted. I've filed a PR: #9.

from ember-cli-notifications.

ynnoj avatar ynnoj commented on July 24, 2024

@griffind That PR should fix your issue. Pull, test and let me know. If it does I'll bump the release.

Thanks @lolmaus.

from ember-cli-notifications.

griffind avatar griffind commented on July 24, 2024

@ynnoj Yup that did the trick! I can't get the animations to work though, so I'll start looking into that when I get home.

https://github.com/griffind/fixtureTest

Thanks for all help @lolmaus and @ynnoj .

from ember-cli-notifications.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.