Initial Model value not shown on UIControls about simpletwowaybindingios HOT 5 CLOSED

I can see one caveat in your solution: whenever a control binds to an observable, it will notify all observers it's value even though it is not changed. These are unnecessary invocations which we can avoid if we modify Bindable as:

public func bind(with observable: Observable<BindingType>) {
        if let _self = self as? UIControl {
            _self.addTarget(Selector, action: Selector{ self.valueChanged() }, for: [.editingChanged, .valueChanged])
        }
        self.binder = observable
        //addition here.
        if let val = observable.value {
            self.updateValue(with: val)
        }
        //addition end.
        self.observe(for: observable) { (value) in
            self.updateValue(with: value)
        }
    }

this will ensure that the Bindable control which is asking to bind with Observable updates if the observable already had a set value.

from simpletwowaybindingios.

Implemented in dd32e58
This is now available as release version 0.0.2.

from simpletwowaybindingios.

@AnnieNinaJoyceV sorry for a super delayed response. I was away on a vacation.
In my opinion, I would set up my data, separate from my setup of bindings. The ViewModel, in this case, is not a traditional view model. Its primary focus is to provide bindings and observables which can change at later stages. Hence in the example, I was visualizing it as:

override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)
        self.navigationItem.title = "Survey Form"
        setupBindings()
        viewModel.companyName.value = "Something"
    }

However, I do see reason in your requirement. If you have an implementation please raise a pull request, else I will have this implemented in a day's time.

from simpletwowaybindingios.

Uhm no! As said in my first post, tweaking the bind function has it fixed.
I will wait for your implementation. Since, I am not very sure whether the tweaking is proper.
Hope you had a nice vacation!! 👍

from simpletwowaybindingios.

Great!! 👍

from simpletwowaybindingios.