Choose a linter and formatter about manim HOT 16 CLOSED

Whatever we use to check aside, it looks like black and pylint are the ones to go with.

from manim.

For anyone still confused about whether Codacy is free for OS, it looks like it is:

from manim.

+1 black and +1 pylint

from manim.

👍 for pylint. How about Codacy?

from manim.

@naveen521kk what is codacy for?

from manim.

Codacy is a Code Quality checker.

from manim.

It's paid though I think?

from manim.

Its free for Open source. So how about adding it. It checks every PR whether it is well formatted or not.

from manim.

Its free for Open source. So how about adding it. It checks every PR whether it is well formatted or not.

Sadly, it's only free for teams of 4 people or smaller. We have at least eleven people who'd like to continue to work on the Manim Community repo.

https://support.codacy.com/hc/en-us/articles/208942945-Plans-and-Billing

It's stated at the very bottom of the linked page.

from manim.

Its free for Open source. So how about adding it. It checks every PR whether it is well formatted or not.

Sadly, it's only free for teams of 4 people or smaller. We have at least eleven people who'd like to continue to work on the Manim Community repo.

https://support.codacy.com/hc/en-us/articles/208942945-Plans-and-Billing

It's stated at the very bottom of the linked page.

Checking it out, its for people who want Codacy for a private repository there is a 4 people and for an OS there is nothing so. And also they say number of people who manage the codacy page and not number of collaborators who contribute to this repository. It's free for OS.

from manim.

Checking it out, its for people who want Codacy for a private repository there is a 4 people and for an OS there is nothing so. And also they say number of people who manage the codacy page and not number of collaborators who contribute to this repository. It's free for OS.

Users are developers contributing to the repository and any team member with access to the code analysis results on the Codacy UI. Your organization should have as many users as your repositories have contributors.

I may be understanding this wrongly, but they say that all the people who are contributers are also Users and all users will get access to the analysis results on the Codacy UI.

from manim.

from manim.

Codacy help in checking PR who may have not use pylint while writing code. It uses pylint or something similar to check the code in cloud. @leotrs .

from manim.

I think running black on Travis CI achieves the same.

from manim.

It seems like we have chosen a linter and a formatter, so this issue has ran its course. We can continue discussion in #33 for travis setup.

from manim.

@yoshiask sounds good. TBH it's still not clear to me what it would offer on top of pylint + black. If there is still a need for it then let's open a different issue focusing on codacy :)

from manim.