Comments (9)
Right col should not have the top padding.
from manifold.
Got it! Will fix when I get a spare moment.
from manifold.
Has this been fixed? I'm not able to reproduce on Chrome or Firefox on any window size.
from manifold.
It has not, AFAIK. It was an issue as of yesterday or the day before. Add another page record in the rails console p = Page.create(title: "test page, slug: "test"
and see if you can reproduce. I can't remember exactly what fields are required on Pages, so if it doesn't save, check p.errors
or p.valid?
and fix whatever is wrong.
from manifold.
I did a bunch of tests with @SMaxOwok and discovered what I believe is the root of the issue. If you take a look at the DOM in your example above, there will likely be an empty <li>
tag with a link to a page
that isn’t showing a nav_title
. The subsequent <li>
has padding on top of it because of sibling spacing.
I was able to reproduce this repeatedly by creating a new page in the console without a nav_title:
p = Page.create(title: "Test Page", slug: "test", creator_id: "e126836d-1b19-4ca9-b942-870b64e0a3cc")
. This will ad a valid page, and an empty
show_in_footer
and nav_title
are nil on the page. This won’t break the layout the first time, but if you add two pages this way (with unique names and slugs), you should see this bug.![manifold scholarship 2017-05-04 17-15-28](https://cloud.githubusercontent.com/assets/1628239/25729887/494cee9c-30ed-11e7-90d1-b4ffd68b020c.png)
We can of course address this bug in the view by hiding pages without nav_title
s and show_in_footer
in the view, but I wanted to run it by you first before addressing it in the Javascript as Max voiced that some of these fields should be setup as required on the model themselves. That said, if there are going to be pages without nav_titles, I will address that in the view, too! Please advise @zdavis .
from manifold.
Ahh.. ideally, nav_title would be optional and title would be required. We'd show nav_title if set, and fallback to title if it's not set.
from manifold.
Thanks for digging into this one!
from manifold.
This fix is present in the PR according to Naomi. It's lacking any tests, however, and I've asked @SMaxOwok to add them. Accordingly, I'm re-assigning this issue to Max.
from manifold.
Test added
f95b85d
from manifold.
Related Issues (20)
- Remove Project Deletion as an Option for Project Editors HOT 1
- Add Bulk Upload Option for Reader Accounts and Maker Accounts
- Public Reading Group JOIN button confirmation message HOT 2
- Members of a Reading Group cannot leave the group HOT 3
- Citation metadata?
- Built-in Text-to-Speech for Accessibility HOT 2
- Official VPAT for Manifold HOT 1
- Advance buttons at bottom of all notes page returns user to text HOT 2
- Radio buttons on create reading group page not working HOT 1
- Sort Projects by Recency
- Allow RG annotations to be sorted by creation date HOT 1
- Scrolling issue on visibility drawer HOT 2
- Unable to click off of annotation modal HOT 4
- Can only view first 20 Project Collections in the backend HOT 1
- Provide useful error message when manifest ingest references missing file
- Adding Project Editors to a journal is not loading HOT 1
- Clicking resource thumbnails in the text causes URL to traverse from using the slug to using the UUID HOT 1
- Use URL instead of # in href property of next/previous button a-links on Project Resources list page HOT 2
- Assign URL to view of page with annotation open HOT 1
- Simplification and enhancement of metadata json in export packages HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from manifold.