Introducing a merge lock? about anime-offline-database HOT 4 CLOSED

I think that's very good, it's the best thing to do I think.

from anime-offline-database.

I am obviously biased towards this solution 😉

Only override rules should be necessary, locking every entry would be overkill.

1-to-1 makes more sense if most of the failed merges are small (only anidb didn't merge into an entry with 3 other links), while the other one is safer but takes more space.

Does merging duplicates mean you can get multiple links per website? e.g. two anidb links

Deleted entries should be removed automatically, now or in the future

from anime-offline-database.

@floflo2607 thanks for the rapid feedback. I appreciate it!

@BeeeQueue thank you for your feedback

I am obviously biased towards this solution wink

Obviously ;)

Only override rules should be necessary, locking every entry would be overkill.

Exactly. That's what I tried to express in my EDIT1. Every entry would be a possibility and could be partially automated, but it's unnecessary and as you said: overkill.

1-to-1 makes more sense if most of the failed merges are small (only anidb didn't merge into an entry with 3 other links), while the other one is safer but takes more space.

I tend towards the safe version. The file size is negligible. It wouldn't be bigger than the database file and the only operation that uses it is the script.

Does merging duplicates mean you can get multiple links per website? e.g. two anidb links

Yes. There are always cases of duplicated anime. Currently myanimelist is the one with the most. Just as an example... there are currently four entries for Cooking with Valkyries. This can happen if the anime titles are created, but the mods didn't approve them yet. That is different for anbidb. On anidb unapproved anime are not available. And of course it's possible that there are approved duplicates, because mistakes can happen ;)

Deleted entries should be removed automatically, now or in the future

For the anime-offline-database.json this is already the case. This would even be the case if an entry is listed in the merge-lock.json. It would then be removed from the anime-offline-database.json anyway. Only the merge-lock.json might contain some zombies entries. But I don't think that this is critical, because it's only be a meta file for the automated process and not meant to be used by users. So this is something that could be fixed later on.

@ all
Any other thoughts? Is there anyone who can say that he or she would be at least interested in contributing?

from anime-offline-database.

I've added the whole merge lock stuff and updated the contribution guidelines.

And created two sample PRs.

from anime-offline-database.