Add a relaxed retry period to fetching errors about hacs_waste_collection_schedule HOT 6 CLOSED

fixed in release 1.16.0

from hacs_waste_collection_schedule.

I agree that the home assistant log should not be flodded with error messages. From my experience, the services are available almost 100% (to be honest, I have never experienced an outage). Therefore a missing fetch is a noticeable failure which I have no doubt to write to the log (once per day). Do you have other experiences?

from hacs_waste_collection_schedule.

Seems like it. In fact two of my Home Assistant instances that query the AWM München web service have the issue in their log. #106 Can't currently say when or how often this happens.

Happy to keep an eye out for it.

Therefore a missing fetch is a noticeable failure

While at it, maybe you could improve the message a little. The typical end user will only be distracted by the object address and the error can be omitted. In fact the error can probably be further disected

from hacs_waste_collection_schedule.

Traced the error and had to find out that @jberrenberg already commited a fix. Thanks! 47f8250

Food for thought: This would have been a lot easier without the cascade of super generic try ... except Exception blocks in the code. Python offers a lot more than that. Example: After removing them it took me seconds to identify the error and a solution.

Feel free to close the issue

from hacs_waste_collection_schedule.

Agree. The error message and the try .. except cascade is bad. Feel free to submit a PR :-)

from hacs_waste_collection_schedule.

I would be happy to but I feel this is a job better suited for someone who has a deeper understanding of the project, to make the right structural decisions.

Let's discuss. I would probably approach this by putting a try...except block around entries = self._source.fetch() alone. This method is just too explosive looking at all the different sources already implemented. Next I would break out different Exception classes to narrow down the error. Alternatively or additionally use the traceback library to recover the trace for logging. In case of doubt I would always want more logging details.

from hacs_waste_collection_schedule.