Rate limiting not working about shopify-graphql-elixir HOT 6 CLOSED

I pushed a fix for a limiter of false not working. Still working on the limiter itself.

from shopify-graphql-elixir.

The limiter does work. We use it in production. However, I believe there is a race condition that may be shutting the limiter partition down prematurely which results in this error. I’ll look into it.

Thanks for reporting.

from shopify-graphql-elixir.

If I set the limiter to false I get this:

** (exit) exited in: GenServer.call(false, {:start_child, {{Shopify.GraphQL.Limiter.Partition, :start_link, [[parent: false, 
partition_id: "rhino-camera-gear.myshopify.com"]]}, :temporary, :infinity, :supervisor, [Shopify.GraphQL.Limiter.Partition]}}, 
:infinity)
    ** (EXIT) no process: the process is not alive or there's no process currently associated with the given name, possibly 
because its application isn't started
    (elixir 1.10.4) lib/gen_server.ex:1013: GenServer.call/3
    (shopify_graphql 1.4.0) lib/shopify/graphql/limiter.ex:48: Shopify.GraphQL.Limiter.start_partition/3
    (shopify_graphql 1.4.0) lib/shopify/graphql/limiter.ex:23: Shopify.GraphQL.Limiter.send/3
    (appapi_phx 0.1.9) lib/appapi_phx/shopify/product_load.ex:200: AppapiPhx.Shopify.ProductLoad.do_product_query/5
    (appapi_phx 0.1.9) lib/appapi_phx/shopify/product_load.ex:21: anonymous fn/1 in 
AppapiPhx.Shopify.ProductLoad.find_active_stores/0
    (elixir 1.10.4) lib/enum.ex:1396: Enum."-map/2-lists^map/1-0-"/2

from shopify-graphql-elixir.

Just a heads up. I added a limiter option to disable partition monitoring. This should prevent limiter partitions from shutting down which I think should prevent this error from happening. I believe this is a race condition which makes it difficult to verify. If you continue to have problems let me know.

To disable partition monitoring you can pass monitor: false to the :limiter_opts config option. It's documented in the README.

I'm currently in the process of rebuilding the limiter to hopefully remove this problem.

from shopify-graphql-elixir.

Thanks for the update. I'm currently working around this issue by using a sleep function, it might not be the most efficient, but it seems to work reliably. I'll try to test out the limiter again in the near future.

from shopify-graphql-elixir.

I’ve done multiple iterations on this and have this working in production so I’m going to close this issue.

from shopify-graphql-elixir.