Enforce python coding standards about mala HOT 6 CLOSED

In GitLab by @RandomDefaultUser on Jan 12, 2021, 23:02

There is no such thing as a HZDR coding standard that I'm aware of. However, I'll use this issue to collect suggestions for improving the code.

• from foo import * is not considered pythonic and can lead to module shadowing and hard-to-find bugs. Instead use from foo import bar, Baz
• be pep8 compliant: Even though I don't agree with all formatting implemented in black, I find myself running black -l79 *.py more and more these days

By Schmerler, Dr. Steve (FWCC) - 131252 on 2021-01-12T23:02:38 (imported from GitLab)

from mala.

In GitLab by @RandomDefaultUser on Jan 13, 2021, 09:54

Yes the "HZDR" was a misunderstanding on my part. I use pycharm and that checks for pep8 compliance if I am not mistaken, I just haven't gone through the whole code yet. I will do that soon. I will also pythonify the import statements.

By Fiedler, Lenz (FWU) - 146409 on 2021-01-13T09:54:37 (imported from GitLab)

from mala.

In GitLab by @RandomDefaultUser on Jan 14, 2021, 10:32

Yes, pycharm also checks for unused imports. I will look into those as well.

By Fiedler, Lenz (FWU) - 146409 on 2021-01-14T10:32:42 (imported from GitLab)

from mala.

In GitLab by @RandomDefaultUser on Jan 13, 2021, 18:50

There is also flake8 and similar tools that show pep8 violations and, more useful I think, unused imports etc. I assume IDEs like PyCharm already do that? FWIW, I stumbled upon

ex07_dos_analysis.py:4:1: F401 'scipy.optimize.toms748' imported but unused

By Schmerler, Dr. Steve (FWCC) - 131252 on 2021-01-13T18:50:10 (imported from GitLab)

from mala.

In GitLab by @RandomDefaultUser on Mar 2, 2021, 21:46

Code should be PEP8 compliant with !41.

By Fiedler, Lenz (FWU) - 146409 on 2021-03-02T21:46:54 (imported from GitLab)

from mala.

In GitLab by @RandomDefaultUser on Jan 13, 2021, 00:53

changed title from Enforce {-HZDR -}python coding standards to Enforce python coding standards

By Schmerler, Dr. Steve (FWCC) - 131252 on 2021-01-13T00:53:18 (imported from GitLab)

from mala.