Comments (40)
@srcristofher so when the main repo updates, and your forked repo is outdated, all you need to do is go to git bash and give the following commands:
if you are not already in the repo environment:
cd markdown-dungeon
To get upstream/update your fork, you git pull
to pull all the new changes from the original repo, to your forked one.
git pull
How to do it online:
At the top, you will see this:
just press fetch upstream, and the green button.
Need any more help, feel free to ask.
from markdown-dungeon.
@ming-tsai And can you please check my discussion post regarding my inquiry #152
from markdown-dungeon.
Hi! I would like to add some rooms for the COVID-19 dungeon, if this is okay for you.
from markdown-dungeon.
time-travel dungeon #165
from markdown-dungeon.
I would like to work on Time-Travel year 1800, because it's looking sooo poor :D
I already prepared some rooms and floors, they are waiting to commit.
from markdown-dungeon.
Very creative @Karguel1995
from markdown-dungeon.
I worked on improving grammar on floor 6 in English normal dungeon, files 1-4. I think the result is more enjoyable for English readers.
from markdown-dungeon.
@ming-tsai sorry to ping you but can you please review my pr #198.
Tysm.
from markdown-dungeon.
Hi, can I help with this issue? I would like to make a pull request.
from markdown-dungeon.
Okis, I'm waiting for your pull request 🙂
Here is my pull request #155 please review thanks :)
from markdown-dungeon.
@ming-tsai Would be good to have time travel based dungeons. I am adding one but it's very basic right now.
from markdown-dungeon.
I made a pr with some .md pages added to the time travel section of the dungeon.
from markdown-dungeon.
May I contribute?
from markdown-dungeon.
I would like to add more rooms/floors in the future, but for now I added a short sub-story to English>normal-dungeon!
from markdown-dungeon.
Thank you for responding! Are you able to review the pr for me?
from markdown-dungeon.
I'm a new contributor and I'm thinking about adding a dungeon. I will send a pull request when I'm done.
from markdown-dungeon.
It is my first time using GitHub for contributing to an open source project.
I have read the README and some guides to GitHub.
Am I correct in assuming following workflow:
0 Find issue you want to work on
1 Comment that you want to work on this issue
2 Fork the repository
3 Make a new branch in your fork
4 work on the new branch
5 create a pull request
6 comment what you did and in which pull request
I have made some spelling edits in pull request #216. If these (and the way I did them) are okay, i would try to make a new merge request for adding some rooms next.
from markdown-dungeon.
Added some rooms for the normal-dungeon: #217
Also tried to add to the README: #218
from markdown-dungeon.
Yes @antonyren-carleton, I will wait for your pull request
from markdown-dungeon.
@ming-tsai And can you please check my discussion post regarding my inquiry #152
Ok, I'll check it out
from markdown-dungeon.
Okis, I'm waiting for your pull request 🙂
from markdown-dungeon.
@ming-tsai Would be good to have time travel based dungeons. I am adding one but it's very basic right now.
Yes, this repo is as you say
from markdown-dungeon.
May I contribute?
Yes @kazuma2448
from markdown-dungeon.
Hi @ming-tsai, I found sci-fi-dungeon incomplete and would like to create/extend it to more rooms/floors.
so can i work on this issue ?
Thank you, waiting for your response.
from markdown-dungeon.
Hi @ming-tsai, I found sci-fi-dungeon incomplete and would like to create/extend it to more rooms/floors.
so can i work on this issue ?
Thank you, waiting for your response.
Yes, I will wait for your pull request.
from markdown-dungeon.
I already did the room. Now I don't have any idea how to make the PR properly. What happened if the original repo is updated in comparison to mine master_branch? 🍡
from markdown-dungeon.
@srcristofher do you mean what happens if the original repo updates, but your fork is outdated?
from markdown-dungeon.
Exactly. I meant that :)
from markdown-dungeon.
hi , please assign me i want to work
from markdown-dungeon.
hi , please assign me i want to work
Hi @mohitahlawat2001,
This issue is not assignable, you just open a pull request and mention it on this issue
from markdown-dungeon.
Hello, I would like to contribute to this issue by adding more floors and rooms to the time-travel dungeon. However, when I try to push, Github says that I don't have write access to the repo and should contact the repo admin.
from markdown-dungeon.
Hello, I would like to contribute to this issue by adding more floors and rooms to the time-travel dungeon. However, when I try to push, Github says that I don't have write access to the repo and should contact the repo admin.
Have you forked the repo first @catherinepham ?
Sorry I just saw the pr. Thank you.
from markdown-dungeon.
Thank you for responding! Are you able to review the pr for me?
Hi @catherinepham,
Your pull request @ hkumar0132 will be review it
from markdown-dungeon.
I would also like to create some rooms and floors for the dungeon, I will be raising pr in the comming time.
from markdown-dungeon.
Hi I want to make a pr on this issue, can I create more rooms now?
from markdown-dungeon.
Yeah sure @ShatilKhan
from markdown-dungeon.
Hi! This is my first time contributing to open source. Do I need to be assigned to the issue to start making a new dungeon? Or can I just start working on it and make a PR whenever?
P.S.: I fixed a typo and made the PR #235 . Hope it's alright.
from markdown-dungeon.
Hi, I would like to add floors and rooms to the time travel dungeon. Is that ok or is there something else I could work on?
from markdown-dungeon.
Can I work on this?
from markdown-dungeon.
Collaborated with @ShadowDraco to create a mario inspired dungeon. Submitted a PR #245
from markdown-dungeon.
Related Issues (20)
- Improvise COVID-19 dungeon HOT 13
- Link not found HOT 10
- Shouldn't We Add Translations HOT 12
- Open Source Projects/Repositories HOT 6
- Linking HOT 2
- Charts for journey's HOT 9
- What is going on with folder number 9 in English Normal Dungeon? HOT 2
- A new PR for test welcome bot
- No way to go back to home page HOT 4
- This is a test for discord webhooks
- Spanish translation HOT 3
- Proofread README.md HOT 2
- Fix: Footer url is pointing to https://material-ui.com/ HOT 1
- Add icons to it HOT 10
- We are not participating the event Hacktoberfest 2022 HOT 1
- error while compiling HOT 2
- Animation suggestion HOT 3
- italian normal-dungeon
- General Question - Maintenance? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdown-dungeon.