Comments (3)
That's weird, crust already has code to avoid duplicates even before you created the issue: https://github.com/maidsafe/crust/blob/2231aa2aeae069f61b7fe3f8a38fa5ff18d50cb2/examples/crust_node.rs#L59-61
I examined your example and I found no duplicate node. The sorted output is easier to spot:
Tcp(V4(127.0.0.1:41734))
Tcp(V4(127.0.0.1:41743))
Tcp(V4(127.0.0.1:41751))
Tcp(V4(127.0.0.1:41759))
Tcp(V4(127.0.0.1:41767))
Tcp(V4(127.0.0.1:41776))
Tcp(V4(127.0.0.1:41784))
Tcp(V4(127.0.0.1:41792))
Tcp(V4(127.0.0.1:41800))
Tcp(V4(127.0.0.1:41808))
Tcp(V4(127.0.0.1:41820))
Tcp(V4(127.0.0.1:41828))
Tcp(V4(127.0.0.1:41834))
Tcp(V4(127.0.0.1:41842))
Tcp(V4(127.0.0.1:41852))
Tcp(V4(127.0.0.1:41860))
Tcp(V4(127.0.0.1:41868))
Tcp(V4(127.0.0.1:41876))
Tcp(V4(127.0.0.1:41884))
Tcp(V4(192.168.1.93:38087))
Tcp(V4(192.168.1.93:38096))
Tcp(V4(192.168.1.93:38104))
Tcp(V4(192.168.1.93:38112))
Tcp(V4(192.168.1.93:38120))
Tcp(V4(192.168.1.93:38129))
Tcp(V4(192.168.1.93:38137))
Tcp(V4(192.168.1.93:38145))
Tcp(V4(192.168.1.93:38153))
Tcp(V4(192.168.1.93:38161))
Tcp(V4(192.168.1.93:38173))
Tcp(V4(192.168.1.93:38181))
Tcp(V4(192.168.1.93:38187))
Tcp(V4(192.168.1.93:38195))
Tcp(V4(192.168.1.93:38205))
Tcp(V4(192.168.1.93:38213))
Tcp(V4(192.168.1.93:38221))
Tcp(V4(192.168.1.93:38229))
Tcp(V4(192.168.1.93:38237)
The other 19 all have 2 >
OTOH, this may be, indeed, a problem.
from crust.
And it's not weird if a node establish three connections to some another node under localhost. Each connection will use a different network card (virtual loopback, read network card...).
from crust.
Yes agreed, will close this issue for now. I think Prakash actually got the code done while we were in last sprint. So thanks for looking around/
from crust.
Related Issues (20)
- Generate Crust ID ourselves
- Dynamic connections manager
- Remove message priorities HOT 1
- Report about dropped messages HOT 2
- Solve head of line blocking HOT 1
- Simplify bootstrap cache
- External reachability test should not make a connection attempt fail
- Unable to connect to local peer on localhost in example HOT 3
- Connection attempt fails HOT 6
- Message Splitting HOT 1
- Remove CrustUser
- Remove PrivConnectionInfo
- Rename prepare_connection_info
- Remove (dis)connect API and make the Send API take peer-information
- Connection Pool
- Is there a method to obtain a peer port. (Q&A)
- Exhaustively Document the nat traversal techniques used.
- Example Code HOT 1
- Fix dyn issues on 1.37
- Is moving to futures and async/await being considered?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crust.