Comments (6)
hmm, I didn't realize it's issue 12 .
Original comment by [email protected]
on 11 Mar 2011 at 1:47
from boar.
Original comment by [email protected]
on 11 Mar 2011 at 1:53
Attachments:
from boar.
Good catch. This is a bug in how offset checkouts are handled. The update
procedure excludes all files outside the current workdir by only including the
ones starting with the offset of the current workdir. That is, if the offset is
"workdir", it should include "workdir/file1.txt" but exclude
"workdir_longer/file2.txt". The broken test only checks if the filename starts
with the offset, even if that is only the beginning of a dir name. This causes
some unexpected files be passed on to another subroutine which notices that
something is wrong, and throws the given exception. The corrected version
should check if the files starts with the offset plus a dir separator.
Original comment by [email protected]
on 12 Mar 2011 at 6:03
- Changed state: Started
from boar.
Fixed in changeset 305:47928f30f85f. I solved it in a different way than the
given patch (it caused some other tests to fail). Thanks for noticing this
problem, it might have been a while before this subtle but serious bug would
had been found otherwise. Please verify that it works.
Original comment by [email protected]
on 13 Mar 2011 at 4:57
- Changed state: Fixed
from boar.
it works, cool.
Original comment by [email protected]
on 16 Mar 2011 at 2:07
from boar.
Original comment by [email protected]
on 16 Mar 2011 at 2:24
- Changed state: Verified
from boar.
Related Issues (20)
- AssertionError: All filenames should be unicode
- Show progress when commit HOT 4
- Should be able to do status and update even with broken manifest
- Folders are not deleted HOT 1
- files that have been uploaded via ci should not have to be re-uploaded if the command was interrupted HOT 1
- Too restrictive permissions on session folders HOT 1
- Canceled import causes MutexLocked error on subsequent import. HOT 1
- Dedup on Windows?
- convert big dir to repo without copying
- Race condition causing only the content in the latest of concurrent commits to be visible HOT 2
- When in a working dir, "boar list" could default to the working dir's repo and session
- 'boar ci --quiet' is not very quiet
- Server-side hard errors gives unexpected error messages on client side
- boar hung at the end of a large import HOT 3
- Locked repo timeout causes unfriendly message
- Repository information should be cached locally, at least per operation HOT 1
- Serve multiple repository with a single boar serve HOT 1
- Error importing file with "\" in the filename HOT 4
- Misleading error message when using citation marks in the REPO_PATH in windows HOT 3
- Revert and Update should be seperate commands HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from boar.