Pixel 4a simulation showing up as google sunfish about magiskhidepropsconf HOT 34 CLOSED

I see it... There's a small typo somewhere when setting partition props, so the model value for system, vendor, odm and system_ext get set to just "Pixel". I'll take a closer look in a very near future.

from magiskhidepropsconf.

Please do the needful. Could you let me know when it's done?

from magiskhidepropsconf.

I'm keeping this open until it's been fixed, so you'll know once I close it.

from magiskhidepropsconf.

Fixed in 1671e0c

from magiskhidepropsconf.

from magiskhidepropsconf.

It shouldn't, but you might have to reapply the fingerprint to force a refresh of the system.prop file.

from magiskhidepropsconf.

from magiskhidepropsconf.

Of you've still got issues I'm going to have to see the module logs.

https://github.com/Magisk-Modules-Repo/MagiskHide-Props-Config/blob/master/README.md#logs

from magiskhidepropsconf.

from magiskhidepropsconf.

Attach the log file here in the issue.

from magiskhidepropsconf.

from magiskhidepropsconf.

There's nothing attached to that post. If you're replying through email, you have to visit the website to be able to attach a file.

from magiskhidepropsconf.

How to upload file?

from magiskhidepropsconf.

https://docs.github.com/en/github/managing-your-work-on-github/file-attachments-on-issues-and-pull-requests

from magiskhidepropsconf.

from magiskhidepropsconf.

Ever heard of "Desktop view" in mobile browsers? You could also just post a link to your cloud/sharing service of choice.

from magiskhidepropsconf.

from magiskhidepropsconf.

Bro...I tried this is 3 different roms, in everything this is the scenario. Even one of my friends got the same results. So doesn't that mean the module is faulty??

Yes, that's very possible. But without those logs it's really hard for me to tell (let alone fix if it is broken).

from magiskhidepropsconf.

https://drive.google.com/file/d/1-t8Fvxo-3Zg_F0El5wN1Cqmlu8eF8oAE/view?usp=drivesdk

from magiskhidepropsconf.

Thank you.

Although, everything looks exactly as it should... I can't see anything wrong. When you say that you see that the device is a "Pixel sunfish", were do you see this? There's no "sunfish" anywhere on your device, according to those logs (which isn't surprising really, since you're simulating a "bonito", 3a XL).

Again, were do you see it reporting the wrong props?

from magiskhidepropsconf.

In my gmail login and in an app called "my device" which shows device information.

from magiskhidepropsconf.

In my gmail login

That's probably been cached by Google. Nothing I can do about that...

and in an app called "my device" which shows device information.

Link to the app? Screenshot? Help me help you...

As far as I can see, from the logs you provided, the module works exactly as it should now.

from magiskhidepropsconf.

from magiskhidepropsconf.

Then what could be the problem in your opinion??

Like I said, with Google it's likely an issue with them caching a previous device check.

With the app, I don't know since I don't know exactly which app you're talking about (there are tons of "My device" apps). A link or at least a screenshot would help. It's not checking prop, it seems...

from magiskhidepropsconf.

from magiskhidepropsconf.

As far as I can tell there's nothing wrong. Unless you did not have the Pixel 4a set for simulation when taking that screenshot.

That app simply shows the device name rather than the model for the 4a...

from magiskhidepropsconf.

from magiskhidepropsconf.

I don't know bruh, when I tried other simulation,it would show the name. I tried other pixel devices 2xl, 3xl etc For everything name was shown as "pixel 2xl/3xl" etc

I know, I've tested the app. But from what I can see, the props get set as they should (you can even see this in the other pages of the app). And technically, it's not wrong... The device model is "Pixel 4a" and the device name is "sunfish".

Unless you can show otherwise (there might of course be something I've missed), I'm writing this down as a quirk of that particular app. Case closed.

from magiskhidepropsconf.

from magiskhidepropsconf.

Hmm...I guess that's that. Sorry for wasting your time bruv! Thanks for fast replies! Really appreciate it!

No time was wasted. There was indeed a bug that you helped me find. Thanks for that.

from magiskhidepropsconf.

from magiskhidepropsconf.

from magiskhidepropsconf.

You need to turn on link sharing if I'm going to be able to download that.

from magiskhidepropsconf.

from magiskhidepropsconf.