Comments (7)
For the author headers: find ./ -type f -exec sed -i -r '/^\s\* By.*$/d' {} \;
from magicmirror.
so I guess this is done and can be closed @khassel ?
from magicmirror.
In my understanding of MIT, it is not necessary to mention the license in all files. But I think it's fine to do it.
As a basis for discussion, here is the current header from app.js
:
/* MagicMirror²
* The Core App (Server)
*
* By Michael Teeuw https://michaelteeuw.nl
* MIT Licensed.
*/
And here three spontaneous proposals:
Proposal 1:
author line removed + asterisk below each other
/*
* MagicMirror²
* The Core App (Server)
*
* MIT Licensed.
*/
Proposal 2:
author line removed + license note formulated in more detail + asterisk below each other
/*
* MagicMirror²
* The Core App (Server)
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
Proposal 3:
author line and license note removed + asterisk below each other
/*
* MagicMirror²
* The Core App (Server)
*/
Feel free to tear these proposals apart. The license part in proposal 2 I found in the sources of react.
from magicmirror.
There are even a few ESLint plugins that check the headers. Here is the rule of one of them that seems suitable: https://github.com/nikku/eslint-plugin-license-header/blob/master/docs/rules/header.md
The example there looks very similar to proposal 2.
/**
* Copyright (c) Foo Corp.
*
* This source code is licensed under the WTFPL license found in the
* LICENSE file in the root of this projects source tree.
*/
Edit: But with the ESLint plugin approach, I now see the downside that the headers have to be the same everywhere... Additions like "The Core App (Server)" couldn't be in that block.
from magicmirror.
Proposal 4: Remove headers alltogether. They provide no real information. I would rather have proper jsdoc headers everywhere ;-)
from magicmirror.
from my side we can remove all these headers ...
from magicmirror.
I'm also fine with removing 👍
from magicmirror.
Related Issues (20)
- Weather module Met Office API Gateway migration
- Bug: Compliments module has `anytime` array mandatory HOT 7
- Calendar events can have recurrences after the RRULE recurrence end date HOT 2
- Move Module MMM-awesome-alexa to abandoned modules HOT 2
- move sunclac devdependency to dependencies HOT 1
- Small proposed change to hourly weather precipitation probability styling HOT 4
- Architecture suggestion: new “data sources” category
- Non helpful error message when started in clientonly mode HOT 6
- MMM-OnSpotify module causes MagicMirror to draws things multiple times HOT 10
- online documentation missing many config options for default modules HOT 3
- [weather] unit of config is not respected on broadcasted notifications
- online doc initial page on android phone hamburger menu doesnt respond HOT 7
- short dayname with time there HOT 4
- [calendar] Wrong values on broadcasted fullday events with RRULE
- Initializing buttons using 'MMM-Buttons' for notification sending to 'MMM-StopwatchTimer' induces an error :( HOT 1
- [weather] openweathermap One Call 2.5 will be finally closed in June 2024 HOT 2
- [news feed][feature request] ignore HTML tags in news feed items
- Modules with no header are always redrawn in updateDom, even when module content is unchanged HOT 4
- Error magicmirror 2.27 after upgrade - Blank black screen HOT 5
- Crash on Start possibility HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magicmirror.