Code Monkey home page Code Monkey logo

Comments (10)

shiftedreality avatar shiftedreality commented on September 5, 2024 1

Thanks @hostep

We have a ticket MAGECLOUD-1911 to add post-deploy hook.
We have an internal task to update all environment variables in the template MAGECLOUD-1908

from magento-cloud.

YPyltiai avatar YPyltiai commented on September 5, 2024 1

@hguthrie , please fix DevDocs examples of hooks (https://devdocs.magento.com/guides/v2.2/cloud/project/project-conf-files_magento-app.html#hooks) to be aligned with https://github.com/magento/magento-cloud/blob/master/.magento.app.yaml#L73-L82

Once fixed, this request can be marked as completed.

Thanks!

from magento-cloud.

YPyltiai avatar YPyltiai commented on September 5, 2024 1

@hostep , this cannot be included into template anymore. In latest ECE-Tools to be released 2002.0.12 this file will be extracted from ECE-Tools during composer update process (sample file). It will have all the up to date variables with additional documentation, specified defaults & expected values. This was re-worked, so we can better maintain this file up to date. After 2002.0.12 this file from magento-cloud repo will be removed

from magento-cloud.

shiftedreality avatar shiftedreality commented on September 5, 2024

Changes regarding correct hooks were merged.

from magento-cloud.

hostep avatar hostep commented on September 5, 2024

Thanks @shiftedreality & @billygilbert !

from magento-cloud.

hguthrie avatar hguthrie commented on September 5, 2024

@YPyltiai I noticed this is not quite fixed yet. We have a sprint beginning and this is perfect to add to the sprint.

from magento-cloud.

hguthrie avatar hguthrie commented on September 5, 2024

Updated the hooks samples in the Cloud guide. Per @YPyltiai , this can be closed.

from magento-cloud.

hostep avatar hostep commented on September 5, 2024

I don't agree with closing this issue just yet, my third remark hasn't been fixed yet. The .magento.env.yaml file in this repo still misses certain example configurations, for example:

  • SKIP_HTML_MINIFICATION
  • MYSQL_USE_SLAVE_CONNECTION
  • REDIS_USE_SLAVE_CONNECTION
  • WARM_UP_PAGES
  • ...

from magento-cloud.

YPyltiai avatar YPyltiai commented on September 5, 2024

@shiftedreality , please close the issue. Discussed with Pieter in Slack - we agreed that this can be marked as resolved.

from magento-cloud.

shiftedreality avatar shiftedreality commented on September 5, 2024

Closed

from magento-cloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.