Comments (6)
Me neither :) Thanks for the info!
from baler.
@DrewML just out of curiosity, and if it can be answered quickly and without too much investigation - is this a fundamental limitation of the method or just a case of the dependency resolver needing updated with additional functionality?
from baler.
Hey @maaarghk, thanks for the report.
I could have sworn I had this documented, but apparently not! At this time, there is no official support for the compact
static content deployment strategy.
The original plan was to re-write static content deploy and get rid of the compact
strategy entirely. TBH, I'm not super sold on supporting compact
, but of course I'm open to further feedback on this.
Although it speeds up deployments, it has a performance impact on shoppers in the storefront. One of the goals of this project is to improve storefront performance, so I'm cautious about supporting Magento configurations that can negatively impact the user experience further.
from baler.
Thanks for the feedback! We would have static content cached at the CDN edge so don't expect the storefront performance to suffer. Is there something else about compact which I'm missing here?
from baler.
Is there something else about compact which I'm missing here?
I'm no expert, so feel free to point out if I'm wrong here :)
Last I checked, compact
generated a file called requirejs-map.js
. Instead of using symlinks on the server or server-side rewrites, the store ships a list of all mappings to a shopper.
This is troubling because:
requirejs-map.js
must be downloaded and executed before any modules can be downloaded- The size of
requirejs-map.js
is on average (from what I've seen) over 100kb when uncompressed, which is big
from baler.
@maaarghk no problem!
Going to leave this ticket open now to track pending work.
TODO:
- Update docs explaining that
compact
is not supported, with a brief explanation as to why - Detect when
pub/static
has been deployed withcompact
strategy and warn + exit, instead of just running endlessly
from baler.
Related Issues (20)
- Magento 2.3.4 JS-Translations fall back to default store language HOT 8
- Add new line after sourceMapingUrl HOT 2
- we run baler before or after production mode? HOT 1
- Load many JS files HOT 1
- Maximum call stack size exceeded
- Stuck on creating core bundle file HOT 2
- Define and require Js are not founding with baler HOT 7
- Cannot find module 'source-map-support/register'
- Baler is not working anymore: TypeError: Cannot redefine property: default HOT 2
- Cannot generate bundle file when the locale is "zh_Hant_HK" HOT 2
- How to make baler command to be available in Magento cloud HOT 1
- Error: ENOTDIR: not a directory, scandir - discord.js HOT 1
- Does it work with Magento 2.4?
- Allow for install with php7.4 for testing with magento 2.4
- No movement in 7 months. Abandoned? HOT 4
- Ignore module HOT 1
- No affect on frontend after installing baler HOT 7
- Is this abandoned? HOT 12
- is this project still under maintain ? HOT 3
- Uncaught TypeError: Cannot read properties of undefined (reading 'set')
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baler.