Code Monkey home page Code Monkey logo

Comments (6)

maaarghk avatar maaarghk commented on June 9, 2024 1

Me neither :) Thanks for the info!

from baler.

maaarghk avatar maaarghk commented on June 9, 2024

@DrewML just out of curiosity, and if it can be answered quickly and without too much investigation - is this a fundamental limitation of the method or just a case of the dependency resolver needing updated with additional functionality?

from baler.

DrewML avatar DrewML commented on June 9, 2024

Hey @maaarghk, thanks for the report.

I could have sworn I had this documented, but apparently not! At this time, there is no official support for the compact static content deployment strategy.

The original plan was to re-write static content deploy and get rid of the compact strategy entirely. TBH, I'm not super sold on supporting compact, but of course I'm open to further feedback on this.

Although it speeds up deployments, it has a performance impact on shoppers in the storefront. One of the goals of this project is to improve storefront performance, so I'm cautious about supporting Magento configurations that can negatively impact the user experience further.

from baler.

maaarghk avatar maaarghk commented on June 9, 2024

Thanks for the feedback! We would have static content cached at the CDN edge so don't expect the storefront performance to suffer. Is there something else about compact which I'm missing here?

from baler.

DrewML avatar DrewML commented on June 9, 2024

Is there something else about compact which I'm missing here?

I'm no expert, so feel free to point out if I'm wrong here :)

Last I checked, compact generated a file called requirejs-map.js. Instead of using symlinks on the server or server-side rewrites, the store ships a list of all mappings to a shopper.

This is troubling because:

  1. requirejs-map.js must be downloaded and executed before any modules can be downloaded
  2. The size of requirejs-map.js is on average (from what I've seen) over 100kb when uncompressed, which is big

from baler.

DrewML avatar DrewML commented on June 9, 2024

@maaarghk no problem!

Going to leave this ticket open now to track pending work.

TODO:

  • Update docs explaining that compact is not supported, with a brief explanation as to why
  • Detect when pub/static has been deployed with compact strategy and warn + exit, instead of just running endlessly

from baler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.