No random single note output when primer_midi or primer_melody not supplied about magenta HOT 7 CLOSED

I didn't know that we allowed no primer to be given previously, but you are right. This is the code that picked a random primer:
https://github.com/tensorflow/magenta/blob/4c0050aee5f2bac3f95041a42074cfb6054071c2/magenta/models/shared/melody_rnn_generate.py#L101

We can add this option back in.

from magenta.

Sounds good. Any idea of your time frame for the fix?

from magenta.

Should be a small change, so early next week seems reasonable.

from magenta.

@danabo I am testing a solution to this. Seems to work, have sent a pull request at #124

from magenta.

I created a PR that will fix both issues - bpm flag and no primer is allowed. This was a bit more complicated than I was anticipated, so I thought it would be easier if I fix both in one PR.

from magenta.

Sounds great Daniel. I will close my PR.

On Tue, Aug 2, 2016 at 4:51 PM, Daniel Abolafia [email protected]
wrote:

I created a PR that will fix both issues - bpm flag and no primer is
allowed. This was a bit more complicated than I was anticipated, so I
thought it would be easier if I fix both in one PR.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#121 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFWI7uVCi4dohMVGwU0DuhKvgmwpwpQyks5qb9f9gaJpZM4JYluI
.

from magenta.

Solved by @danabo PR

#128

from magenta.