Code Monkey home page Code Monkey logo

Comments (6)

mafintosh avatar mafintosh commented on August 25, 2024 4

Yup, in Node.js 10 pipeline was added (by me :)) to have pump in core. I still use pump personally whenever I want to support Node.js <10

from pump.

mafintosh avatar mafintosh commented on August 25, 2024 3

Yep!

from pump.

matthiasg avatar matthiasg commented on August 25, 2024 2

Good to hear. Am I correct though that beginning with Node 10 and stream.pipeline pump is not longer required ? If so i think it would be appreciated if the README commented on to why or why not ?

from pump.

lukesims avatar lukesims commented on August 25, 2024

@matthiasg you are correct - the following quote from the Node docs confirms it:

pump is only necessary for Nodejs 8.x or earlier, as for Node 10.x or later version, pipeline is introduced to replace for pump. This is a module method to pipe between streams forwarding errors and properly cleaning up and provide a callback when the pipeline is complete.

from pump.

matthiasg avatar matthiasg commented on August 25, 2024

@mafintosh @lukesims sorry had actually read it in the node docs, but had forgotten about it. It would be sensible to mention in this projects README as well though, to close the loop for people coming from other projects (like I did) trying to figure out whether its required. good work btw

from pump.

lukesims avatar lukesims commented on August 25, 2024

I agree with @matthiasg as it would save future users from making the same side-trip to the Node docs that we all did to reach this conclusion. This is the PR if anyone else is interested - good work @mafintosh :)

from pump.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.