Comments (6)
Yup, in Node.js 10 pipeline was added (by me :)) to have pump in core. I still use pump personally whenever I want to support Node.js <10
from pump.
Yep!
from pump.
Good to hear. Am I correct though that beginning with Node 10 and stream.pipeline pump is not longer required ? If so i think it would be appreciated if the README commented on to why or why not ?
from pump.
@matthiasg you are correct - the following quote from the Node docs confirms it:
pump
is only necessary for Nodejs 8.x or earlier, as for Node 10.x or later version,pipeline
is introduced to replace forpump
. This is a module method to pipe between streams forwarding errors and properly cleaning up and provide a callback when the pipeline is complete.
from pump.
@mafintosh @lukesims sorry had actually read it in the node docs, but had forgotten about it. It would be sensible to mention in this projects README as well though, to close the loop for people coming from other projects (like I did) trying to figure out whether its required. good work btw
from pump.
I agree with @matthiasg as it would save future users from making the same side-trip to the Node docs that we all did to reach this conclusion. This is the PR if anyone else is interested - good work @mafintosh :)
from pump.
Related Issues (20)
- returning last stream HOT 5
- Multiple pumps inside a single task HOT 4
- buffered data in readable stream does not reach writable stream HOT 3
- Pass error in stream.destroy()
- Callback is called when destination file is still open if source stream emits error
- pump + webpack-stream exits watch task HOT 2
- This module is now part of Node.js 10 HOT 3
- MaxListenersExceededWarning: Possible EventEmitter memory leak detected HOT 1
- How to propagate errors in pipe using pump?
- Reduce the size of the npm package by limiting the included files
- pump swallowing errors when read stream is empty HOT 2
- callback in pump firing before _flush complete HOT 2
- Question: Is pump compatible with the request library? HOT 6
- Pump closes the stream after just 16 iterations HOT 2
- Async errors not caught in Node < 10
- Question: when not to use `pump`? HOT 6
- Error are not triggered HOT 2
- Incrementally pipe additional streams & handle split streams HOT 2
- use `pump(zipStream, writeStream)`, the zip file at disk is nested one level more HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pump.