Add file to existing archive about zipstream-php HOT 2 OPEN

Thanks for the reply! Two thoughts:

1. I agree that your proposed addFilesFromZip… method is a better design.
2. I had not considered looping over ZipArchive because I didn’t think there was a way to read the raw stream and write it to ZipStream without the overhead of decompressing/recompressing. However, your suggestion prompted me to look again. It seems like ZipArchive can provide the raw stream. If ZipStream provided API to add a file using a raw stream (i.e. to avoid decompressing/recompressing), I think that would suffice.

from zipstream-php.

@jhammer

Good point about accessing the raw stream. Where did you see that it supports that? If not, this approach would mean that a compressed file would be uncompressed and recompressed when adding it. I don't think that would fulfill your need, right?

Probably a better way would be to just read the zip file from a stream and just forward all file headers / contents & record their position. As soon as the end of central directory header is reached, the entries need to be parsed, the location rewritten and then we continue as normal.

I would be both open to support someone developing this feature and receive a PR or also to implement it myself provided somebody sponsors my time. If you're interested in that, send me an email for the details. (Email is public in my profile)

from zipstream-php.