Code Monkey home page Code Monkey logo

Comments (6)

AODQ avatar AODQ commented on August 21, 2024

By the way, possibly related, but ever since that commit, bvh::SweepSahBuilder crashes when trying to use it to build. I'm assuming it is related to this issue.

from bvh.

madmann91 avatar madmann91 commented on August 21, 2024

Hello, and thank you for the report. I'll have a look. Note that I've since fixed a couple of bugs that I've introduced in that commit, so pulling the repo might just fix this for you. The fix should also improve the performance of bvh::SweepSahBuilder.

from bvh.

madmann91 avatar madmann91 commented on August 21, 2024

I managed to build your project (AODQ/cpu-raytracer, I suppose), but I cannot seem to run it at all. It just gives me the error:

~/P/c/build> ./cpuraytracer -f ../../bench_scenes/kitchen/kitchen.obj
Argument ‘
Aborting (exceptions disabled)...
fish: Job 2, “./cpuraytracer -f ../../bench_s…” terminated by signal SIGABRT (Abort)

from bvh.

AODQ avatar AODQ commented on August 21, 2024

@madmann91 Hey, thanks! I haven't updated it to use your most recent commit, I'll go ahead and do that when I get home.

from bvh.

madmann91 avatar madmann91 commented on August 21, 2024

Also note that bvh::shuffle_primitives now returns the new shuffled array instead of modifying the argument.

from bvh.

AODQ avatar AODQ commented on August 21, 2024

@madmann91 ; ah , that is exactly what was occurring, I had not noticed that change. Thank you. And yes bvh::SweepSahBuilder works now

from bvh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.