Code Monkey home page Code Monkey logo

Comments (6)

macbre avatar macbre commented on May 24, 2024 1

@ldevernay, great idea!

from phantomas.

macbre avatar macbre commented on May 24, 2024 1

@ldevernay, how does a command line option --validate-all-response-codes sounds to you? It will cause all metrics to be returned instead of returning an error due to non-200 response code.

I'm open for discussing the naming here ;)


Inspired a bit by axios/axios#41 and https://axios-http.com/docs/handling_errors.

from phantomas.

ldevernay avatar ldevernay commented on May 24, 2024 1

Hi @macbre,
Thanks for this quick and thorough answer!
I will check with the rest of the team and let you know but this sounds great.

from phantomas.

ldevernay avatar ldevernay commented on May 24, 2024 1

OK, that was fast : as soon as you implement this option, I confirm that we can use this on our side and it might solve our issue with 404 pages (and apparently other error pages as well).
Regarding the naming for the option, I get your point but can't find anything better for now. I think --validate-all-response-codes is clear enough.

from phantomas.

macbre avatar macbre commented on May 24, 2024 1

Great! Will work on that.

Similar: #809 and #823

from phantomas.

ldevernay avatar ldevernay commented on May 24, 2024

Awesome, thx!

from phantomas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.