Not optimal generation of methods which only throw NotImplementedException about asyncgenerator HOT 6 CLOSED

In my opinion we should apply the same idea as for guards/preconditions where we want to fail at the spot without the need to await the call. But after a quick look on the internet I found this, where nobody mentioned the option to only throw the raw exception without wrapping it into a task. Currently I fixed this by throwing a raw exception but I will leave the issue open and do a deeper research about this.

from asyncgenerator.

The same problem could apply also for NotSupportedException and other exceptions, so I think that we shall not wrap into a try/catch block when the first statement is a throw statement.

from asyncgenerator.

Agree. The NotImplementedException was just an example. I was to lazy to write about other exceptions:)

from asyncgenerator.

Shall it be just a throw or return Task.FromException(...)?

from asyncgenerator.

From this it looks like

    public async Task X2Async() {
        throw new NotImplementedException();
    }

Is really overcomplicated version of this:

    public Task X3Async() {
		return Task.FromException(new NotImplementedException());
    }

from asyncgenerator.

As far as I concern the 87643c8 has fixed this issue.

from asyncgenerator.