Pair counts changing depending on number of threads about celllistmap.jl HOT 4 CLOSED

Thanks a lot for the prompt reply - this indeed solved the issue, and I'm glad to know it was just a silly mistake from my side. You're also correct about updating counts[j], as I would be underestimating the pair counts otherwise.

from celllistmap.jl.

Here:

(x, y, i, j, d2, output) -> count_pairs!(i, DD),

output and DD (which name doesn't matter)

must be the same variable. This is just a function definition that for the input variables on the left returns the result of the function on the right.

On the right a variable that is not on the left only appears if it is some data that has to be used but is not provided by the standard interface (like masses, for example)

from celllistmap.jl.

(otherwise you are updating the DD array, which is not threaded, and you have concurrency problems)

from celllistmap.jl.

Also note that within the count_pairs function you may want to update both count[i] and count[j], because the function only runs once per pair. But this is not related to threading.

from celllistmap.jl.