Can you create a wine-lol with the fsync patch please (futex)? about wine-lol HOT 23 CLOSED

I'll have a look at this around the end of this month.

from wine-lol.

I won't do anything until someone properly fixes this S9 thing. Current state is that I can't play at all.

Edit: And there will be no separate wine-lol-fsync. If the patch is too intrusive someone else will have to create and maintain the build.

from wine-lol.

I understand what you mean. Can you at least help me building it? I am using a linux mint 20 distro but I don't how to proceed.

from wine-lol.

With my scripts you can not build at all on Mint. They are Arch Linux PKGBUILD based. To actually build the DEB files this would require you to set up an Arch or (probably better) Manjaro virtual machine, first.

from wine-lol.

oh well i guess i won't get into that stuff then.thanks anyway

from wine-lol.

Yeah thats a cool thing! Please, prevent us when u give it a shot ;)

from wine-lol.

With my scripts you can not build at all on Mint. They are Arch Linux PKGBUILD based. To actually build the DEB files this would require you to set up an Arch or (probably better) Manjaro virtual machine, first.

What do you mean by "(probably better) Manjaro virtual machine"? Do you recommend using Manjaro instead of Arch for running wine-lol?

from wine-lol.

I think he just meant that manjaro is easier to use when you need the PKGBUILD based thing.
By the way, I am using manjaro right now. If you could tell me how to build it, That would be very kind.

from wine-lol.

Exactly. Currently I would suggest Manjaro to noone. If possible use Arch.

from wine-lol.

I think he just meant that manjaro is easier to use when you need the PKGBUILD based thing.
By the way, I am using manjaro right now. If you could tell me how to build it, That would be very kind.

You can easily build wine-lol on Manjaro from AUR but you need an AUR helper for this. For pamac, the command would be pamac install wine-lol, and that's it.
Make sure to enable multilib repos in /etc/pacman.conf if you haven't done it yet (uncomment 2 lines with multilib, then do paman -Syu).
To enable AUR in pamac, uncomment "EnableAUR" in /etc/pamac.conf (or use this command: sudo sed --in-place "s/#EnableAUR/EnableAUR/" "/etc/pamac.conf").
Please note that it will take time to build (30 minutes on my PC).

from wine-lol.

He needs a build for a Debian derivative. And that's not that easy.

And about Manjaro (even if Off-Topic): https://forum.manjaro.org/t/change-of-treasurer-for-manjaro-community-funds/154888

I have more time recently as my exams are written. Still have to go through some other work but I'll come back to this one and do a test build with the fsync patch.

from wine-lol.

I'll give up on this topic for now.

Seems like since wine 5.10 even esync is disabled and fsync doesn't apply at all. It would be possible to hack something into wine 5.6 but then we are basically locked to this version as everything from 5.7 to 5.10 does not launch LoL at all.

For me it even seems like Valve has given up on fsync. No work in that direction...

from wine-lol.

Valve didn't gave up of FSYNC, they are just working to get the kernels patches in a state that is good for upstream, it takes time.
anyway, you could easily add ESYNC that does not need any kernel-side-code to work, is fully user-space
and it works on wine 5.7

Esync patches:
https://github.com/Frogging-Family/wine-tkg-git/tree/fe39d6f5b7b2723492195a0574c270a6d0d61b79/wine-tkg-git/wine-tkg-patches/esync

from wine-lol.

There is no need to patch for esync. It is part of wine-staging. And it was disabled in the latest wine-staging versions as the maintainers did not want to rework it completely for the latest ntdll changes. At least not now as there are still heavy changes in ntdll with every Wine release. But in 5.6 it still was in there and so it should already work. But it will be gone as soon as I'm able to update to a more recent Wine version. So better try it now before it's gone.

But you are right: There is work done to make "something like fsync" work directly in the kernel:
https://www.phoronix.com/scan.php?page=news_item&px=FUTEX2-LPC-2020
This could land pretty soon which most probably also means that we get entirely new fsync patches for this new kernel feature.

from wine-lol.

I success fsync with wine-5.6
https://github.com/yuiiio/wine-lol-src (delete because confusing)

from wine-lol.

For Wine 5.6 it should be possible to just apply one patch (just have to find the right one. There are a few of them for different versions of Wine).

But the problem with this is that, once it gets possible again to upgrade to a more recent version, fsync will be gone again. That's one of the big reasons why I don't want to enable it now.

I really hope that, once the required change is integrated into the kernel, this new feature will be implemented directly in Wine(-staging) and no more manual patching is needed.

from wine-lol.

you are right.
extra patches will be harder to maintain.

from wine-lol.

If you're interested. I added Fsync patch from Tkg and staging+fix in 5.9 top of m-reimer/master
https://github.com/yuiiio/wine-lol/commits/master

from wine-lol.

Actually I don't see a big need to move from 5.6 (old version) to 5.9 (another old version).
As we can't go to anything more "up to date", I would prefer to "never change a running system" for now.

from wine-lol.

I pulled out the patches needed to make the lol work in staging(5.9).https://github.com/yuiiio/wine-lol-src/commits/slim

I've applied those patches on top of 5.18(not staging) (the many ntdll reverts from TKG).https://github.com/yuiiio/wine-lol-src/commits/wine-new-work
It seems to work.(Now I need hack-script about riotclient timeout issue)

from wine-lol.

I noticed that some patches were missed during the tkg rebase.

from wine-lol.

update to 5.18 + tkg's fsync + tkg's missing patch
https://github.com/yuiiio/wine-lol/commit/ea9c74c2d807d17e428aff8438e63911ef9f2341

from wine-lol.

Marking this one WONTFIX now.

Reason: "Futex2" is in the works and once this is finished it will be hopefully available directly in one of the future stable kernels. Once this happens it is very likely that WINE itself will support this "official kernel feature" at some time.

The current state with "futex" is, that literally dozens of commits in a current WINE version have to be reverted to get back to a state where the patch still applies. I don't want to deal with that.

from wine-lol.