Comments (10)
This is just one /guaranteed/ crash. There are other random ones that occur as the round progresses. Testing experimental fixes to help stop this.
Seems to be due to command logging so far.
from byondhook.
Hey, would you please mind saying which server did you try this on? I can't seem to reproduce the issue neither on Goonstation nor Lifeweb, I've pressed tab and hotkey mode seems to switch on/off without crashing.
99% of crashes are due to the the CommandEvent hook, the command logging indeed on very rare occasions trips on access violations when reading the pointer to the command string retrieved from the EAX register.
from byondhook.
Hey, would you please mind saying which server did you try this on? I can't seem to reproduce the issue neither on Goonstation nor Lifeweb, I've pressed tab and hotkey mode seems to switch on/off without crashing.
99% of crashes are due to the the CommandEvent hook, the command logging indeed on very rare occasions trips on access violations when reading the pointer to the command string retrieved from the EAX register.
A variety of servers, ranging from Sojourn to Merchantstation, I tried on both the most recent beyond and the version showcased on the github, both crash instantaneously upon hotkey mode being activated.
This also seems to be related to just hotkey mode being activated, because once you do; any subsequent reconnects instantly crash once you get into the server.
from byondhook.
I can confirm this issue and I'm investigating, very weird.
I'm also focused at the moment on the 514.1584 update which somehow broke the CommandEvent hook and returns an invalid pointer even though nothing inside that function in byondcore.dll has changed. They are also now elevating dreamseeker.exe privileges, I suggest staying on 1583 as of now.
from byondhook.
Hello, please try upgrading to BYOND 514.1584 and compiling commit 22d0d55 and see if it fixes your issue.
Best Regards
from byondhook.
commit 0cc0de6 seems to finally get rid of the issue, including the rare occasional crashing. Please, let me know how it goes
from byondhook.
commit 0cc0de6 seems to finally get rid of the issue, including the rare occasional crashing. Please, let me know how it goes
Will try.
from byondhook.
Past the occasional bug (this), everything seems to now work fine.
Will re-open if new issues arise.
from byondhook.
Alright, sorry to mention that but I believe that is not really a BYONDHook "bug", there's some servers where I can't understand why, multiple child processes of dreamseeker are started (depending on the server, sometimes only on the first join), then the parent process is terminated. The child processes don't have visible windows except for the last one which shows up the game, but it causes the console windows to be opened. I'm pushing a new update soon, by changing "AllocConsole = 1" to 0 in the config.ini file, you will be able to suppress the console window so that these won't show up anymore.
from byondhook.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from byondhook.