Comments (19)
jleclanche
commented on August 17, 2024
Is this still an issue? @paulolieuthier worth taking a look at before 0.8 if it wasnt fixed
from lxqt-panel.
paulolieuthier
commented on August 17, 2024
This snapshot is one month old. @sfalken could you please try again with current master?
from lxqt-panel.
jleclanche
commented on August 17, 2024
@sfalken ping
from lxqt-panel.
sfalken-zz
commented on August 17, 2024
Travelling right now, I will have a look when I get home on Thursday
On Tue, Oct 14, 2014 at 5:35 AM, Jerome Leclanche [email protected]
wrote:
@sfalken https://github.com/sfalken ping
—
Reply to this email directly or view it on GitHub
#73 (comment).
And that's why, when J. Edgar Hoover asks if you're a god, you say yes!
from lxqt-panel.
doktor5000
commented on August 17, 2024
Still valid with released 0.8 tarballs:
make[2]: Entering directory '/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/build' [ 47%] Building CXX object plugin-mount/CMakeFiles/mount.dir/lxqtmountplugin.cpp.o /home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp:31:27: fatal error: LXQtMount/Mount: No such file or directory #include <LXQtMount/Mount> ^ compilation terminated.
Also not sure why empty files are installed by liblxqt-mount:
[user1@localhost lxqt-panel-0.8.0]$ wc -l /usr/include/lxqtmount-qt5/LXQtMount/Providers /usr/include/lxqtmount-qt5/LXQtMount/Mount 0 /usr/include/lxqtmount-qt5/LXQtMount/Providers 0 /usr/include/lxqtmount-qt5/LXQtMount/Mount 0 total
The patch provided by @sfalken works just fine, at least for compiling. Linking fails later on, but that's unrelated to this issue ...
make[2]: Entering directory '/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/build' Linking CXX shared module libpanelsysstat.so /usr/bin/ld: cannot find -lsysstat-qt5
from lxqt-panel.
paulolieuthier
commented on August 17, 2024
This is the same problem Eugene is facing. I'm working on it. I'm not sure I'll get somewhere, but I'm trying.
from lxqt-panel.
luis-pereira
commented on August 17, 2024
@doktor5000 @paulolieuthier @sfalken About the empty files I don't know. But I found the source of error: LXQtMount/Mount: No such file or directory #include <LXQtMount/Mount> ^ compilation terminated.
It affects both Qt4 and Qt5 versions
An qt4 branch has to be created.
from lxqt-panel.
luis-pereira
commented on August 17, 2024
@doktor5000 @sfalken The fix is up. Please test it. There's a new qt4 branch that contains the fix.... imagine that... for qt4 😄 . The Qt5 is on master obviously.
from lxqt-panel.
doktor5000
commented on August 17, 2024
Will there be some kind of bugfix release for 0.8 as it obviously doesn't build as shipped? And yes, will try the patch from master and report back.
from lxqt-panel.
luis-pereira
commented on August 17, 2024
@doktor5000 That has not been decided yet. But that's a possibility
Go ahead and test. If reporting is needed, post verbose logs and the
scripts in question. It makes everything faster.
On Wed, Oct 22, 2014 at 4:00 PM, doktor5000 [email protected] wrote:
Will there be some kind of bugfix release for 0.8 as it obviously doesn't
build as shipped? And yes, will try the patch from master and report back.—
Reply to this email directly or view it on GitHub.
Luís Pereira
from lxqt-panel.
jleclanche
commented on August 17, 2024
If the issues are contained to a few modules we can release 0.8.1 for those yes.
from lxqt-panel.
luis-pereira
commented on August 17, 2024
@jleclanche I do agree. And the numer of modules needing a release will be low.
@doktor5000 Take a look at my reply in the mailing list: http://sourceforge.net/p/lxde/mailman/message/32959793/
from lxqt-panel.
anubisg1
commented on August 17, 2024
the panel 0.8.0 still has the problem
[ 39s] [ 46%] Building CXX object plugin-mount/CMakeFiles/mount.dir/lxqtmountplugin.cpp.o
[ 39s] cd /home/abuild/rpmbuild/BUILD/lxqt-panel-0.8.0/build/plugin-mount && /usr/bin/c++ -DLXQT_ETC_XDG_DIR=\"/etc/settings\" -DLXQT_RELATIVE_SHARE_DIR=\"lxqt\" -DLXQT_RELATIVE_SHARE_TRANSLATIONS_DIR=\"lxqt/translations\" -DLXQT_SHARE_DIR=\"/usr/share/lxqt\" -DLXQT_SHARE_TRANSLATIONS_DIR=\"/usr/share/lxqt/translations\" -DLXQT_VERSION=\"0.8.0\" -DPLUGIN_DIR=\"/usr/lib64/lxqt-panel/\" -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_MIMETYPES -DQT_NO_DEBUG -DQT_XML_LIB -Dmount_EXPORTS -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -g -fvisibility=hidden -fvisibility-inlines-hidden -fno-exceptions -O3 -DNDEBUG -fPIC -I/home/abuild/rpmbuild/BUILD/lxqt-panel-0.8.0/build/plugin-mount -I/home/abuild/rpmbuild/BUILD/lxqt-panel-0.8.0/plugin-mount -isystem /usr/include/QtGui -isystem /usr/include/QtDBus -isystem /usr/include/QtXml -isystem /usr/include/QtCore -I/usr/include/lxqt -I/usr/include/qtxdg -I/usr/include/QtMimeTypes -I/usr/include/lxqt-globalkeys -I/usr/include/lxqt-globalkeys-ui -I/home/abuild/rpmbuild/BUILD/lxqt-panel-0.8.0/build -I/home/abuild/rpmbuild/BUILD/lxqt-panel-0.8.0 -I/home/abuild/rpmbuild/BUILD/lxqt-panel-0.8.0/src -I/usr/usr/include/lxqtmount -I/home/abuild/rpmbuild/BUILD/lxqt-panel-0.8.0/plugin-mount/panel -Wall -o CMakeFiles/mount.dir/lxqtmountplugin.cpp.o -c /home/abuild/rpmbuild/BUILD/lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp
[ 39s] /home/abuild/rpmbuild/BUILD/lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp:31:27: fatal error: LXQtMount/Mount: No such file or directory
[ 39s] #include <LXQtMount/Mount>
[ 39s] ^
[ 39s] compilation terminated.
building with qt4 here. i can't find the proper patch nor a commit that reference this problem
from lxqt-panel.
doktor5000
commented on August 17, 2024
@luis-pereira Regarding your comment about the fix on master, you're referencing lxqt/liblxqt-mount-deprecated@eec19c7 right?
Just tried, and no it doesn't fix the issue. Here's some verbose output, obtained via
cmake -DUSE_QT5=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_VERBOSE_MAKEFILE=ON . make VERBOSE=1
Scanning dependencies of target mount
make[2]: Leaving directory '/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0'
make -f plugin-mount/CMakeFiles/mount.dir/build.make plugin-mount/CMakeFiles/mount.dir/build
make[2]: Entering directory '/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0'
/usr/bin/cmake -E cmake_progress_report /home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/CMakeFiles
[ 47%] Building CXX object plugin-mount/CMakeFiles/mount.dir/lxqtmountplugin.cpp.o
cd /home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/plugin-mount && /bin/c++ -DLXQT_ETC_XDG_DIR=\"/etc\" -DLXQT_RELATIVE_SHARE_DIR=\"lxqt-qt5\" -DLXQT_RELATIVE_SHARE_TRANSLATIONS_DIR=\"lxqt-qt5/translations\" -DLXQT_SHARE_DIR=\"/usr/share/lxqt-qt5\" -DLXQT_SHARE_TRANSLATIONS_DIR=\"/usr/share/lxqt-qt5/translations\" -DLXQT_VERSION=\"0.8.0\" -DPLUGIN_DIR=\"/usr/local/lib/lxqt-panel/\" -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -Dmount_EXPORTS -fvisibility=hidden -fvisibility-inlines-hidden -fno-exceptions -fPIE -fPIE -O3 -DNDEBUG -fPIC -I/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/plugin-mount -I/usr/include/lxqt-qt5 -I/usr/include/qt5xdg -isystem /usr/lib/qt5/include -isystem /usr/lib/qt5/include/QtWidgets -isystem /usr/lib/qt5/include/QtGui -isystem /usr/lib/qt5/include/QtCore -isystem /usr/lib/qt5/mkspecs/linux-g++ -isystem /usr/lib/qt5/include/QtXml -I/usr/usr/include/lxqtmount-qt5 -I/usr/include/lxqt-globalkeys-qt5 -I/usr/include/lxqt-globalkeys-ui-qt5 -I/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0 -I/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/src -I/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/plugin-mount/panel -isystem /usr/lib/qt5/include/QtDBus -isystem /usr/lib/qt5/include/QtX11Extras -Wall -o CMakeFiles/mount.dir/lxqtmountplugin.cpp.o -c /home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp
/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp:31:27: fatal error: LXQtMount/Mount: No such file or directory
#include <LXQtMount/Mount>
^
compilation terminated.
plugin-mount/CMakeFiles/mount.dir/build.make:308: recipe for target 'plugin-mount/CMakeFiles/mount.dir/lxqtmountplugin.cpp.o' failed
make[2]: *** [plugin-mount/CMakeFiles/mount.dir/lxqtmountplugin.cpp.o] Error 1
make[2]: Leaving directory '/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0'
CMakeFiles/Makefile2:684: recipe for target 'plugin-mount/CMakeFiles/mount.dir/all' failed
make[1]: *** [plugin-mount/CMakeFiles/mount.dir/all] Error 2
make[1]: Leaving directory '/home/user1/lxqt-panel/BUILD/lxqt-panel-0.8.0'
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
from lxqt-panel.
anubisg1
commented on August 17, 2024
if building with QT4 , this patch will fix it. still, i think the problem should be fixed in lxqt-mount itself (probably by fixing the pkgconfig file?? )
diff -uNr old-lxqt-panel-0.8.0/plugin-mount/actions/deviceaction.h lxqt-panel-0.8.0/plugin-mount/actions/deviceaction.h
--- old-lxqt-panel-0.8.0/plugin-mount/actions/deviceaction.h 2014-10-26 11:09:10.294777261 +0100
+++ lxqt-panel-0.8.0/plugin-mount/actions/deviceaction.h 2014-10-26 11:12:41.252764945 +0100
@@ -31,7 +31,7 @@
#include <QObject>
#include <QSettings>
-#include <LXQtMount/Mount>
+#include <lxqtmount/LXQtMount/Mount>
namespace {
class MountDevice;
diff -uNr old-lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp
--- old-lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp 2014-10-26 11:09:10.294777261 +0100
+++ lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp 2014-10-26 11:10:03.142774175 +0100
@@ -28,7 +28,7 @@
#include "lxqtmountplugin.h"
#include "lxqtmountconfiguration.h"
-#include <LXQtMount/Mount>
+#include <lxqtmount/LXQtMount/Mount>
#include "actions/deviceaction.h"
#include "popup.h"
#include "mountbutton.h"
diff -uNr old-lxqt-panel-0.8.0/plugin-mount/menudiskitem.cpp lxqt-panel-0.8.0/plugin-mount/menudiskitem.cpp
--- old-lxqt-panel-0.8.0/plugin-mount/menudiskitem.cpp 2014-10-26 11:09:10.298777261 +0100
+++ lxqt-panel-0.8.0/plugin-mount/menudiskitem.cpp 2014-10-26 11:14:07.573759906 +0100
@@ -27,7 +27,7 @@
#include <QDesktopServices>
#include "menudiskitem.h"
-#include <LXQtMount/Mount>
+#include <lxqtmount/LXQtMount/Mount>
#include <XdgIcon>
#include <QDebug>
#include <QUrl>
diff -uNr old-lxqt-panel-0.8.0/plugin-mount/popup.cpp lxqt-panel-0.8.0/plugin-mount/popup.cpp
--- old-lxqt-panel-0.8.0/plugin-mount/popup.cpp 2014-10-26 11:09:10.294777261 +0100
+++ lxqt-panel-0.8.0/plugin-mount/popup.cpp 2014-10-26 11:17:23.411748473 +0100
@@ -29,7 +29,7 @@
#include <QGridLayout>
#include <QLabel>
#include <QDesktopWidget>
-#include <LXQtMount/Mount>
+#include <lxqtmount/LXQtMount/Mount>
#include "menudiskitem.h"
#include "popup.h"
from lxqt-panel.
luis-pereira
commented on August 17, 2024
@doktor5000 Yes, Altough it was needed it didn't solve the problem.
The source of the problem was found here:
http://sourceforge.net/p/lxde/mailman/lxde-list/?viewmonth=201410&viewday=22
On Sun, Oct 26, 2014 at 6:08 AM, anubisg1 [email protected] wrote:
if building with QT4 , this patch will fix it.
But from what i can see, the problem is actually liblxqt-mount. the
pkgconfig file is pointing to /usr/include rather than
/usr/include/lxqtmount. fixing that should be the real solution.(path to build with qt4)
diff -uNr old-lxqt-panel-0.8.0/plugin-mount/actions/deviceaction.h
lxqt-panel-0.8.0/plugin-mount/actions/deviceaction.h
--- old-lxqt-panel-0.8.0/plugin-mount/actions/deviceaction.h 2014-10-26
11:09:10.294777261 +0100
+++ lxqt-panel-0.8.0/plugin-mount/actions/deviceaction.h 2014-10-26
11:12:41.252764945 +0100
@@ -31,7 +31,7 @@#include
#include
-#include <LXQtMount/Mount>
+#include <lxqtmount/LXQtMount/Mount>namespace {
class MountDevice;
diff -uNr old-lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp
lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp
--- old-lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp 2014-10-26
11:09:10.294777261 +0100
+++ lxqt-panel-0.8.0/plugin-mount/lxqtmountplugin.cpp 2014-10-26
11:10:03.142774175 +0100
@@ -28,7 +28,7 @@#include "lxqtmountplugin.h"
#include "lxqtmountconfiguration.h"
-#include <LXQtMount/Mount>
+#include <lxqtmount/LXQtMount/Mount>
#include "actions/deviceaction.h"
#include "popup.h"
#include "mountbutton.h"
diff -uNr old-lxqt-panel-0.8.0/plugin-mount/menudiskitem.cpp
lxqt-panel-0.8.0/plugin-mount/menudiskitem.cpp
--- old-lxqt-panel-0.8.0/plugin-mount/menudiskitem.cpp 2014-10-26
11:09:10.298777261 +0100
+++ lxqt-panel-0.8.0/plugin-mount/menudiskitem.cpp 2014-10-26
11:14:07.573759906 +0100
@@ -27,7 +27,7 @@#include
#include "menudiskitem.h"
-#include <LXQtMount/Mount>
+#include <lxqtmount/LXQtMount/Mount>
#include
#include
#include
diff -uNr old-lxqt-panel-0.8.0/plugin-mount/popup.cpp
lxqt-panel-0.8.0/plugin-mount/popup.cpp
--- old-lxqt-panel-0.8.0/plugin-mount/popup.cpp 2014-10-26
11:09:10.294777261 +0100
+++ lxqt-panel-0.8.0/plugin-mount/popup.cpp 2014-10-26 11:17:23.411748473
+0100
@@ -29,7 +29,7 @@
#include
#include
#include
-#include <LXQtMount/Mount>
+#include <lxqtmount/LXQtMount/Mount>
#include "menudiskitem.h"
#include "popup.h"—
Reply to this email directly or view it on GitHub.
Luís Pereira
from lxqt-panel.
doktor5000
commented on August 17, 2024
FWIW, the intial report here and my build is qt5-only. So liblxqt-mount pkgconfig file still needs to be fixed, right?
from lxqt-panel.
luis-pereira
commented on August 17, 2024
On Mon, Oct 27, 2014 at 3:46 PM, doktor5000 [email protected]
wrote:
FWIW, the intial report here and my build is qt5-only. So liblxqt-mount
pkgconfig file still needs to be fixed, right?
@doktor5000 They are missing the Requires and the version fields. It's on
my TODO list. However that is not the source of the "problem".
Luís Pereira
from lxqt-panel.
jleclanche
commented on August 17, 2024
As far as I understand, this has been fixed. If it hasn't, please reopen a bug on the main tracker.
from lxqt-panel.
Related Issues (20)
- Incorrect support clock custom format for T
- 100% CPU usage HOT 1
- [Feature request] Whisker-like Start menu HOT 8
- The clock may be incorrect almost by one second
- Wrong code in World-Clock without bad consequence
- Minor main menu up/down arrow navigation issues HOT 1
- Configure Panel & Monitor Settings don't really match
- lxqt-panel segfaults on wayland with default configuration HOT 19
- Urgency hint is not cleared when using mouse wheel to switch between applications. HOT 8
- On login applications started on another workspace not displayed in taskbar HOT 1
- Hitting "enter" closes "Add plugin" dialog
- Application menu shows lots of entries for Flatpak applications HOT 7
- Urgent window hint stuck on desktopswitch plugin after corresponding window vanishes before being focused HOT 4
- No parameters can be passed to the mixer command HOT 4
- Should/can PipeWire be added to Volume Control plugin directly? HOT 3
- System tray icons applications don't recieve wheel (probably also tooltip) events HOT 55
- High CPU load in case of QT_SCALE_FACTOR > 1 HOT 11
- Screen flickering if hovering volume icon on wayland HOT 4
- Volume Control shows wrong volume when Panel is restarted HOT 9
- No notification showed under wayland with "Notify about volume changes with keyboard" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lxqt-panel.