I have a special executable of Firefox, for example, in a local directory. When I dro

I was able to get the desired result with: <div class="highlight highlight-source-

Yes, you're right. This works: <div class="highlight highlight-source-diff notran

Executables dropped on Quick Launch should get a default icon instead of path text about lxqt-panel HOT 5 CLOSED

lxqt commented on August 17, 2024

Executables dropped on Quick Launch should get a default icon instead of path text

from lxqt-panel.

Comments (5)

willbprog127 commented on August 17, 2024

I was able to get the desired result with:

diff --git a/plugin-quicklaunch/quicklaunchaction.cpp b/plugin-quicklaunch/quicklaunchaction.cpp
index 83b31dc..27c43c0 100644
--- a/plugin-quicklaunch/quicklaunchaction.cpp
+++ b/plugin-quicklaunch/quicklaunchaction.cpp
@@ -53,8 +53,9 @@ QuickLaunchAction::QuickLaunchAction(const QString & name,
     m_settingsMap["exec"] = exec;
     m_settingsMap["icon"] = icon;

-    if (icon.isNull())
-        setIcon(XdgIcon::defaultApplicationIcon());
+    if (icon == "" || icon.isNull()) {
+        setIcon(QIcon::fromTheme("image-missing"));
+    }
     else
         setIcon(QIcon(icon));

from lxqt-panel.

jleclanche commented on August 17, 2024

XdgIcon::defaultApplicationIcon() is the better call.

I didn't look too close but when can the icon be null at all? If it can be both empty and null this might be an issue with qtxdg.

from lxqt-panel.

willbprog127 commented on August 17, 2024

Yes, you're right. This works:

diff --git a/plugin-quicklaunch/quicklaunchaction.cpp b/plugin-quicklaunch/quicklaunchaction.cpp
index 83b31dc..ec9447b 100644
--- a/plugin-quicklaunch/quicklaunchaction.cpp
+++ b/plugin-quicklaunch/quicklaunchaction.cpp
@@ -53,8 +53,9 @@ QuickLaunchAction::QuickLaunchAction(const QString & name,
     m_settingsMap["exec"] = exec;
     m_settingsMap["icon"] = icon;

-    if (icon.isNull())
+    if (icon == "" || icon.isNull()) {
         setIcon(XdgIcon::defaultApplicationIcon());
+    }
     else
         setIcon(QIcon(icon));