Comments (5)
I was able to get the desired result with:
diff --git a/plugin-quicklaunch/quicklaunchaction.cpp b/plugin-quicklaunch/quicklaunchaction.cpp
index 83b31dc..27c43c0 100644
--- a/plugin-quicklaunch/quicklaunchaction.cpp
+++ b/plugin-quicklaunch/quicklaunchaction.cpp
@@ -53,8 +53,9 @@ QuickLaunchAction::QuickLaunchAction(const QString & name,
m_settingsMap["exec"] = exec;
m_settingsMap["icon"] = icon;
- if (icon.isNull())
- setIcon(XdgIcon::defaultApplicationIcon());
+ if (icon == "" || icon.isNull()) {
+ setIcon(QIcon::fromTheme("image-missing"));
+ }
else
setIcon(QIcon(icon));
from lxqt-panel.
XdgIcon::defaultApplicationIcon()
is the better call.
I didn't look too close but when can the icon be null at all? If it can be both empty and null this might be an issue with qtxdg.
from lxqt-panel.
Yes, you're right. This works:
diff --git a/plugin-quicklaunch/quicklaunchaction.cpp b/plugin-quicklaunch/quicklaunchaction.cpp
index 83b31dc..ec9447b 100644
--- a/plugin-quicklaunch/quicklaunchaction.cpp
+++ b/plugin-quicklaunch/quicklaunchaction.cpp
@@ -53,8 +53,9 @@ QuickLaunchAction::QuickLaunchAction(const QString & name,
m_settingsMap["exec"] = exec;
m_settingsMap["icon"] = icon;
- if (icon.isNull())
+ if (icon == "" || icon.isNull()) {
setIcon(XdgIcon::defaultApplicationIcon());
+ }
else
setIcon(QIcon(icon));
from lxqt-panel.
Should I submit this as a patch, or...? I'm not really proficient on git yet, so not sure if a PR should be done instead?
from lxqt-panel.
A PR would be nice, IMO.
from lxqt-panel.
Related Issues (20)
- Worldclock sometimes displays another timzone after resume from suspend
- [Feature request] - User-configurable icon sizes for QuickLaunch and StatusNotifierPlugin
- KDE Workaround to focus issues HOT 2
- Fancy Menu: misbehavior if an favorite app is disinstalled. HOT 9
- enable using color in panel custom widgets HOT 4
- CMake: warning about minimum version required too old HOT 1
- frequent freeze / hang that blocks some X11 keyboard/mouse events HOT 11
- Panel spams system log in an infinite loop freezing the system HOT 12
- System freezes randomly, Dbus Error pointing to lxqt-panel HOT 25
- [Feature request] Add info line about middleclick in worldclock → timezones HOT 2
- lxqt-panel: symbol lookup error: /usr/lib64/lxqt-panel/libvolume.so: undefined symbol: _ZNK14PluginSettings5groupEv HOT 6
- Show Deskop widget not working HOT 7
- Wrong icon sizes in the fancy menu? HOT 4
- [Feature request] Move responsibility for device management to pcmanfm-qt (plugin-mount) HOT 2
- Detection of overlapping windows for autohide stopped working across all virtual desks except for the first (leftmost) one HOT 12
- Task Manager plugin: buttons shifting position when opening or closing windows HOT 3
- [Feature request]Allow lxqt-panel to be built on a system without wayland HOT 1
- Settings not applied for dual monitor setup under wayland HOT 2
- [Bug] Fancy Menu: Shortcut behaviour HOT 6
- Fancy Menu: Problem with Breeze and HiDPI scaling HOT 34
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lxqt-panel.