Repeaters are sorted in the first column of Modules table in users.php about xlxd HOT 12 CLOSED

After checking dashboard (1) cods, here a better fix for the issue.

However, I don't know how to shift the table-striped by 1, hence I used non-striped class for the enclosed table in the module

73,
Yngwie
Bx2AFC

$ diff users.php users_fix2.php
54c54
<       <table class="table table-striped table-hover">
---
>       <table class="table table-striped">
72a73,74
> echo '<tr>';
>
75a78,81
>     echo '
>    <td valign="top" style="border:0px;padding:0px;">
>
>       <table class="table table-hover">';
88c94
<             <tr>
---
>               <tr>
92a99,102
>    echo '
>       </table>
>
>    </td>';
94a105,106
> echo '</tr>';
>

from xlxd.

Hi yngwiechou, sorry for the delay in the answer. I was out of reach this week.

Do you have this dashboard in use in a XLX server? I'm part of the XLX724 team and we only have users on Module B, so I have no way to test those changes.

I have some work that need to be done by tomorrow. I can take a look carefully on Monday.

from xlxd.

Luiz,

I can do tests if you like. I have various repeaters that can be linked to all modules on my XLX. Also some clients linke MMDVM, UP4DAR, DVmega...

vy73 de Florian DF2ET

from xlxd.

Hi Florian,

That would be really helpful.

TY, 73

from xlxd.

Hi Florian and Yngwie,

I made some changes to the code that I believe would fix that problem. Please try the code in my repo https://github.com/lamaral/xlxd to see if it fixes that problem.

Thank you.

from xlxd.

Luiz,

the fix works fine. This is what the current state in LX3JL repo looks like:

And this is the result from the test with your branch:

In both cases DB0BS-B was linked to my XLX module B. So the code was buggy and your fix is good. I think you can put it into a PR for the LX3JL repo.

vy73 de Florian DF2ET

from xlxd.

Hi Luiz,

The fix is works fine.

But if you can take a look my proposed fix #2, the presentation on web will be a little bit better

Thanks a lot.

Regards,
Yngwie

On Jul 17, 2016, at 03:05, Luiz Fernando Ribeiro Amaral [email protected] wrote:

Hi Florian and Yngwie,

I made some changes to the code that I believe would fix that problem. Please try the code in my repo https://github.com/lamaral/xlxd https://github.com/lamaral/xlxd to see if it fixes that problem.

Thank you.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #7 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AThxkRL8ddZ_vRJ-H6MSitr2d91zrDMiks5qWStmgaJpZM4JNfHm.

from xlxd.

Hi Luiz,

Here my fix.

https://github.com/yngwiechou/xlxd

Please help to take a look to see if it is better.

Regards,
Yngwie

On Jul 17, 2016, at 10:07, Yngwie Chou [email protected] wrote:

Hi Luiz,

The fix is works fine.
<Screen Shot 2016-07-17 at 10.05.31.png>

But if you can take a look my proposed fix #2, the presentation on web will be a little bit better

<Screen Shot 2016-07-17 at 09.57.47.png>

Thanks a lot.

Regards,
Yngwie

On Jul 17, 2016, at 03:05, Luiz Fernando Ribeiro Amaral <[email protected] mailto:[email protected]> wrote:

Hi Florian and Yngwie,

I made some changes to the code that I believe would fix that problem. Please try the code in my repo https://github.com/lamaral/xlxd https://github.com/lamaral/xlxd to see if it fixes that problem.

Thank you.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #7 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AThxkRL8ddZ_vRJ-H6MSitr2d91zrDMiks5qWStmgaJpZM4JNfHm.

from xlxd.

I believe this issue can be closed, as a fix was provided in the pull request #9.

from xlxd.

Hi guy's, Jean-Luc will close the issue when he is back from holidays.
Good work !

from xlxd.

@yngwiechou could close this issue as well as he was the author of this issue ;-)

from xlxd.

Of course :-)

from xlxd.