Decompression Failed with status 6 on kernel 6.7.9 about rtw88 HOT 5 CLOSED

Thanks for chasing this issue down. The difference between your two kernels is that the second turned comporession on. When it did, the Makefile detected this and compressed its modules appropriately.

I also added the zstd compression when the distro has modules with the .zst suffix, which mine actually does. That explains why I was not seeing the problem.

from rtw88.

Obviously, there is a bug in your kernel. I cannot fix that.

The best I can offer is to prevent the rtw88 build from compressing the modules. In Makefile, find the line that says "#Handle the compression option for modules in 3.18+", and delete it and the following 6 lines. The last one will be "#endif".

from rtw88.

hum, it worked but it's odd since all other modules are working fine and compressed with xz too. So i dug up a bit.

I tried to check differences between modules I already have and the one build with this makefile:
Every modules use CRC32 as integrity check but xz utility by default use CRC64 as integrity check and it seems the kernel doesn't support CRC64: https://docs.kernel.org/staging/xz.html?highlight=xz#notes-on-compression-options

I don't know what change between my two kernel, if it's the DECOMPRESS options or they enforce integrity check that was not done before but it's seems to be the problem.

So I change the Makefile to force CRC32 while compressing with xz and it work perfectly.

I change a bit too, the uninstall part (even if i have not change the modprobe -r that seems to don't reflect all the chipsets modules support, as of today)

diff --git a/Makefile b/Makefile
index 852929a..8f07c2e 100644
--- a/Makefile
+++ b/Makefile
@@ -158,7 +158,7 @@ ifeq ($(COMPRESS_GZIP), y)
        @gzip -f $(MODDESTDIR)/*.ko
 endif
 ifeq ($(COMPRESS_XZ), y)
-       @xz -f $(MODDESTDIR)/*.ko
+       @xz -f -C crc32 $(MODDESTDIR)/*.ko
 endif
 
        depmod -a $(KVER)
@@ -174,7 +174,13 @@ uninstall:
        @modprobe -r rtw_8723de
        @modprobe -r rtw_8723de
        @modprobe -r rtw_8723de
+ifeq ($(COMPRESS_GZIP), y)
+       @rm -f $(MODDESTDIR)/rtw_*.ko.gz
+else ifeq ($(COMPRESS_XZ), y)
+       @rm -f $(MODDESTDIR)/rtw_*.ko.xz
+else
        @rm -f $(MODDESTDIR)/rtw_*.ko
+endif
        
        @depmod $(DEPMOD_ARGS)
        

from rtw88.

Hi,

The problem was reintroduced during this merge: 37e4b3c

The merge has override some change from the Makefile. CRC 32 for xz, zstd.

from rtw88.

I think I fixed it.

from rtw88.