Warcraft III installer about lutris HOT 26 CLOSED

Hi !
It would be very nice to have a Warcraft III installer indeed :)

For the moving part you can write a move command like:

- move:
    src: $GAMEDIR/videos
    dst: $GAMEDIR/videos.bak

for the regedit part you would have to add a set_regedit task:

- task:
    path: HKEY_CURRENT_USER\Software\Blizzard Entertainment\Warcraft
    key: Gfx OpenGL
    value: 1
    description: Switching to OpenGL renderer
    name: set_regedit

I won't close the issue so you can tell me with anything goes wrong

from lutris.

Thanks! The script looks as follows. I will try it out in the weekend :)

files:
- installer: N/A:Please select the installer for Warcraft III: Reign of Chaos
installer:
- insert-disc
- lutris: installer
- move: 
    src: $GAMEDIR/Movies 
    dst: $GAMEDIR/Movies_
- task:
    path: HKEY_CURRENT_USER\Software\Blizzard Entertainment\Warcraft
    key: Gfx OpenGL
    value: 1
    description: Switching to OpenGL renderer
    name: set_regedit

from lutris.

Very good !

BTW, the insert-disc command now expects a 'message' argument and accepts a 'requires' argument that can check the presence of a given file. For example:

- insert-disc:
    message: "Please insert Warcraft III CD",
    requires: Setup.exe

Neither of these arguments are required in the code but there's a bug when there's an installer command without any argument, so please put at least one ^^

Oh, and the "lutris: installer" line won't do much ;)

from lutris.

Warcraft III without the videos is such a shame ! Have you tried this workaround ?

from lutris.

Hi. Thanks for both suggestions!

As I understand the workaround, you use winecfg to set the following
Windows version: Windows XP
Graphics:

• Automatically capture the mouse... etc
• Allow the window manager to control the windows
• Emulate a virtual desktop (the size of your game resolution, e.g., 1280x1024)

Libraries:

• winegstreamer (disabled)
  and run the game with the -opengl setting (same effect as the regedit)

I tried it out in my installation of Warcraft III (not using the lutris installer) and it now plays the videos although instead of scaling to my screen resolution (1280x1024), they play in a 800x600 window in the upperleft of the screen.
If I resize the screen it shows correctly. I do not remember if the videos behave like this in Windows though...
I think the biggest disadvantage is that you have to emulate a virtual desktop with the same size as you play in and if you change the resolution in-game from that, it does not look good.
I am not highly familiar with Wine but maybe it can be configured to resize the virtual desktop to the current resolution, when the resolution changes.

from lutris.

Hi, sorry about the delay but I get the error "Invalid YAML data(scanner error)" when I try to submit the installer. Can any of you see something wrong in it?

files:
- war-installer: 'N/A:Please select the installer for Warcraft III: Reign of Chaos'
installer:
- insert-disc:
    message: "Please insert the CD for Warcraft III: Reign of Chaos",
    requires: install.exe
- task:
    description: Installing Warcraft III: Reign of Chaos, 
    executable: '${war-installer}',
    name: wineexec, 
    prefix: $GAMEDIR
- move: 
    src: $GAMEDIR/Movies 
    dst: $GAMEDIR/Movies_
- task:
    path: HKEY_CURRENT_USER\Software\Blizzard Entertainment\Warcraft
    key: Gfx OpenGL
    value: 1
    description: Switching to OpenGL renderer
    name: set_regedit

from lutris.

Sorry about the delay too.

• Remove the commas at the end of lines
• Add quoting marks around "Installing Warcraft III: Reign of Chaos" because there's a ":" in the text.

from lutris.

I submitted it now. Turns out the issues were caused by tabs, however I did not get the opengl + movie disable part into the installer and I am unable to edit it....

from lutris.

I've added them in and published it. Thanks for the submission ! :)

from lutris.

I tried out the installer but it gets stuck after selecting the install.exe from the cd with the message.

"Installing Warcraft III: Reign of Chaos"
KeyError('requires',)

My guess is that the line

requires: install.exe

in the insert-disc part as hinted by strycore is required?

from lutris.

yes, the 'requires' parameter should point to a file that will be present in the CD-Rom. It can be Setup.exe or anything else as long as it's at the root of the CD-Rom.

from lutris.

Great, if someone is able to edit the installer I will try it out again :)
The installer file in the CD-Rom root is called 'install.exe'

from lutris.

I edited it. You can also make tests with a local version by saving it in a .yml file and launching it using the command:
lutris -i "path/to/installer.yml"

from lutris.

Thanks for the tip! It made it much easier to test :)
The installation looks quite good now! I even get launchers in Unity Dash 👍
There are still a few issues left:

1. The lutris installer only works if the user do not change the default install location when asked by the warcraft installer
2. It should be clear that the warcraft installer must be closed after installation (like in PlayOnLinux)
3. The last regedit task does not accept the 'prefix' option, although I assume it is necessary to specify the right wine prefix?
4. Uninstallation still seems risky. I could uninstall with winetricks but that is not exactly userfriendly :)

exe: drive_c/Program Files/Warcraft III/Warcraft III.exe
files:
- {war-installer: 'N/A:Please select the installer for Warcraft III: Reign of Chaos'}
game: {prefix: $GAMEDIR}
installer:
- task: {description: 'Installing Warcraft III: Reign of Chaos', executable: '${war-installer}',
    name: wineexec, prefix: $GAMEDIR}
- move: {dst: $GAMEDIR/drive_c/Program Files/Warcraft III/Movies_, src: $GAMEDIR/drive_c/Program Files/Warcraft III/Movies}
- task: {description: Switching to OpenGL renderer, key: Gfx OpenGL, name: set_regedit,
    path: HKEY_CURRENT_USER\Software\Blizzard Entertainment\Warcraft, value: 1, prefix: $GAMEDIR}
name: 'Warcraft III: Reign of Chaos'
runner: wine
version: CD (with OpenGL)

from lutris.

Could this be closed? Not really a "bug".

from lutris.

@dennisjj4 this place is for any type of issues and suggestions, not only bugs. As long as we don't have a specific place for issues with installers, I think this is the best place to discuss them.

@PCSan I have updated the script.
Edit :: as for your left issues :

1. This is true for every Wine installer. We will probably have a global message like PlayOnLinux for Wine games asking the user not to change the install path.
2. Same
3. (again ? ;) Do you get an error message ? Looking from the code, it should accept the prefix parameter.
4. Strycore added a protection to prevent deletion of system and home folder, though I don't think it's really safe yet (I've seen a case where after a unfinished install the game's path was the parent folder where all other games are stored. I've yet to reproduce it). So yeah, make sure you check the path before deleting games from Lutris.

from lutris.

This can almost be closed, the installer seems to be in good shape :) I do not own a copy of Warcraft 3 so I can't really test this so @PCSan will take the final decision on whether the installer is good enough.

I have added the 'prefix' option to set_regedit very recently (between @PCSan and @Xodetaetl's comments)

True, the folder deletion rules are a bit more secure but not secure enough. The initial goal was to isolate the 'can be deleted' rule in a separate funciton and prevent catastrophes. Now, I still have to add further security: for example checking that the folder is indeed the folder of the game and not the runner's default path.

from lutris.

sorry about the numbering, but you get what it meant :p
For this particular installer, I believe only issue 3 with the regedit should be dealt with as the others are issues for Lutris in general. I did not save the error message but I believe it was something along 'prefix not supported' and it sounds like it has been added very recently :)
Is it going to be in the next release of Lutris?
On another note, Warcraft III does not show up as installed in the Lutris client. Clicking either Play or Configure does nothing and the only Uninstall option is to remove it from the library. Perhaps it is because I installed from the command line?

from lutris.

Is it going to be in the next release of Lutris?

It's in 0.3.3 :)

On another note, Warcraft III does not show up as installed in the Lutris client. Clicking either Play or Configure does nothing and the only Uninstall option is to remove it from the library. Perhaps it is because I installed from the command line?

Yeah... synchronization is not working great yet. You have to switch between Icon and List views to update the view, or restart Lutris.

from lutris.

What? If there were known issues regarding the Icon/List view I would have fixed them before releasing lutris 0.3.3.
I have tested installing games manually or from the website, everything seems to work as expected.

If a game is not starting, there must be some kind of error showing up in the shell, please paste the output of Lutris when you try running the game (in debug mode, with the -d parameter)

from lutris.

I didn't bother reposting an issue yet, but yes, synchronization is still not working for me. I'll make a proper report soon.

from lutris.

Thanks for the fast responses! I will try update Litrus and reinstall Warcraft again later this week!
I tried to run litrus with the -d parameter.
Starting up Litrus produced the output

DEBUG    2014-01-27 21:24:39,531 [config]:registering protocol
DEBUG    2014-01-27 21:24:40,018 [jobs]:Async call: sync_icons
DEBUG    2014-01-27 21:24:40,018 [jobs]:Async call: sync
DEBUG    2014-01-27 21:24:40,019 [api]:Syncing game library
DEBUG    2014-01-27 21:24:40,019 [api]:Fetching game library
DEBUG    2014-01-27 21:24:40,020 [resources]:Fetching icons
DEBUG    2014-01-27 21:24:40,609 [api]:61 games in remote library
DEBUG    2014-01-27 21:24:40,610 [api]:61 games in local library
DEBUG    2014-01-27 21:24:40,611 [api]:0 games added

Pressing 'play' on Warcraft produced the output

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/lutris/gui/lutriswindow.py", line 249, in on_game_clicked
    InstallerDialog(game_slug, self)
  File "/usr/lib/pymodules/python2.7/lutris/installer.py", line 593, in __init__
    self.interpreter = ScriptInterpreter(game_ref, self)
  File "/usr/lib/pymodules/python2.7/lutris/installer.py", line 72, in __init__
    self.script = self._fetch_script(game_ref)
  File "/usr/lib/pymodules/python2.7/lutris/installer.py", line 104, in _fetch_script
    script_contents = open(game_ref, 'r').read()
IOError: [Errno 21] Er et filkatalog: 'warcraft-iii-reign-of-chaos'

"Er et filkatalog" is Danish for "Is a file catalogue".
Pressing 'Configure' produced no output.

from lutris.

Ok, I don't know which version of Lutris you are using but line 104 of installer.py in certainly not this one in Lutris 0.3.3.
Make sure you are running the latest version of the program or else it's very hard for us to help you (and you will encounter a lot more bug if you don't)

from lutris.

I tried installing with Lutris 0.3.3 and now it looks much better :)
There were no errors while installing and the game launches and updates just fine! I also tried making an application menu shortcut and the referred icon in .local/shar/lutris/icons seems to be missing. However I would say we could close this issue and I will try to move on to the Frozen Throne expansion ;)

from lutris.

Glad things are working better now :)

from lutris.

Last news: Wine 1.7.13 includes a fix for Warcraft videos, you should try it @PCSan ! :)

from lutris.