`_` route for custom 404 pages about submillisecond HOT 3 CLOSED

Should the _ catch all route inherit the middleware just like other routes?

For example:

router! {
    use LoggingMiddleware;

    GET "/foo" => foo_handler
    GET "/bar" => bar_handler
    _ => handle_404
}

Should routes handled by handle_404 call the logging middleware like a regular request?

from submillisecond.

Yes, I think so. To stay consistent.

from submillisecond.

I would expect we treat the value after _ => to be a handler rather than a subrouter... but what if we want to support a subrouter being there instead?

Sadly, our currently implementation treats handler functions different to subrouters. Subrouters are called directly with subrouter(__req, __params, __reader), and handlers with Handler::handle(handler, __req).

An example of using a router with the catch all system would be with static_dir! macro:

router! {
    "/static" => {
        GET "/foo.txt" => serve_foo
        _ => static_dir!("./static")
    }
}

The most simple way to treat the value diffrently is to check if it's prefixed with a HTTP method, and if so, treat it as a handler, otherwise subrouter. But that means there wouldn't be an easy way to serve a custom 404 handler if the catchall could be prefixed with handlers. They'd have to do:

router! {
    GET "/foo" => foo_handler
    GET _ => handle_404
    POST _ => handle_404
    PATCH _ => handle_404
    // ...and so on for each method
}

Perhaps we need to introduce a http keyword for any http method, but to indicate that we treat the value as a handler.
For example:

router! {
    GET "/foo" => foo_handler // handler
    ANY _ => handle_404 // handler
    _ => SUBROUTER_404 // subrouter
}

from submillisecond.