VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT handling about gfxreconstruct HOT 9 CLOSED

This impacts capturing any Source 2 game so for example can be reproduced with Dota 2. When I use gfxrecon I have to run with a command-line option to disable VK_EXT_pipeline_creation_cache_control to workaround this issue (vulkan_disable_ext_pipeline_creation_cache_control).

from gfxreconstruct.

This error makes sense. Because the pipeline cache was invalidated, so it needed to compile. But it had VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT flag, so vkCreateGraphicsPipelines returned VK_PIPELINE_COMPILE_REQUIRED, and pipeline was VK_NULL_HANDLE. And then, because pipeline was VK_NULL_HANDLE, it crashed in the following command that was related to pipeline.

We might have a couple solutions.

1. Require user to get a new capture to have a new pipeline cache.
2. Add a replay option to disable VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT flag.
3. I think you do something in your program, when VK_PIPELINE_COMPILE_REQUIRED happens. We could do the same thing if you tell us what you do.

I think No. 2 could be a better idea. What do you think? @zmike @bradgrantham-lunarg

vkspec:
VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT specifies that pipeline creation will fail if a compile is required for creation of a valid VkPipeline object; VK_PIPELINE_COMPILE_REQUIRED will be returned by pipeline creation, and the VkPipeline will be set to VK_NULL_HANDLE.

from gfxreconstruct.

In my personal view, I think gfxrecon should always fail vkCreateGraphicsPipeliens if VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT is specified, the traces are likely going to not be replayable since the most likely reason an app is asking is to avoid compiling a pipeline. Since you don't have access to the cache data (it might have come from an internal driver cache rather than a loaded VkPipelineCache) this just seems like it's not going to work in most cases.

from gfxreconstruct.

I think we could have an option (default on?) to always return COMPILE_REQUIRED if the application passed VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT to vkCreate*Pipelines. Would that work?

from gfxreconstruct.

My response was before you edited your comment - I think that sounds like a plan.

from gfxreconstruct.

@zmike @danginsburg could you help to view this PR? Thank you very much.
#1160

from gfxreconstruct.

@locke-lunarg I'm not familiar with the gfxreconstruct codebase, but at a conceptual level the change seems like it should resolve this issue. Thanks!

from gfxreconstruct.

I am in the same boat, looks OK to me but I'm not familiar with the code base.

from gfxreconstruct.

#1160 was merged. @danginsburg and @zmike do you think you will have a chance to try out this change in dev?

from gfxreconstruct.