Ending slash is output for pattern without ending slash about regexparam HOT 14 CLOSED

Great! Thanks!

from regexparam.

Understood, just making sure.

I still have to investigate some dependents, but I just pushed the code (and way more tests) to #6

I have to step out for a little bit, but if you can verify that that PR behaves as expected, would be appreciated. Back soon 👍

from regexparam.

Everything in the Polka & Navaid worlds still work with this change :)

from regexparam.

Hey, I'll have to look at this carefully as this library is also the basis of Polka and a few other big projects. I think I can make a change without affecting anything too much (including performance), but may I ask why you're using results[0]? It's generally always the [1] result and onwards that are cared about, since those are the groups.

In that regard, there's no difference. Both are "clean" dashboard value

from regexparam.

results[0] is matched url. I use it in a few places in my project.
https://github.com/ReactTraining/react-router/blob/master/packages/react-router/modules/matchPath.js#L48

from regexparam.

Right, fair enough :) I will investigate and update here later tonight or tomorrow. I already have it working/solved locally, but I have to examine the impact & ensure nothing else is adversely affected

from regexparam.

Perhaps you knew this, but ptr doesn't always trim the trailing slash: https://codesandbox.io/s/thirsty-hopper-swxme

Just wanted to highlight that clarification while I was looking into behavioral differences

from regexparam.

I did not know. Though I don't see difference in your codesandbox. Did you save it?

from regexparam.

Oops, try now

from regexparam.

I see. I think this is ok. In my app there is usually only root trailing slash which is handled separately. But I'm good if it's easier for you to consider this case too.

from regexparam.

Do you need loose mode? Without loose, the trailing is always stripped.

from regexparam.

Yes, I use match only loosely. For example on page /dashboard I open modal with item /dashboard/id. And modal uses own matcher for this.

from regexparam.

Thanks Luke!

from regexparam.

No problem, thanks for checking it out :) Now live btw

from regexparam.