Some issues with parse5 about gettext-extractor HOT 4 CLOSED

FYI: I've moved the necessary @type packages to dependencies in v3.3.2

from gettext-extractor.

In the latest version I've upgraded to version 5 of the parse5 library which seems to be the cause of your issue. Are you also compiling the dist files of this package? Because that's not really necessary since it's already compiled from TypeScript to JavaScript.

In any case, a minimal working example of the problem would greatly help in figuring out what's happening.

from gettext-extractor.

hmm adding @types/[email protected] works for me but you are right that my project should use already compiled version of your library

Also minimal example is just typescript file with:

import { GettextExtractor, JsExtractors } from 'gettext-extractor';

parsed with

tsc --module commonjs

and tsconfig.json like this:

{
  "compilerOptions": {
    "moduleResolution": "node",
    "target": "es6",
    "module":"es6",
    "lib": ["es2015", "es2016", "es2017", "dom"],
    "strict": true,
    "sourceMap": true,
    "declaration": true,
    "allowSyntheticDefaultImports": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "declarationDir": "dist/types",
    "outDir": "dist/lib",
    "types": [
      "node"
    ],
    "typeRoots": [
      "node_modules/@types"
    ]
  },
  "include": ["src"]
}

And no dependency on parse5 becouse when you add dependency "parse5": "^5.0.0" problems doesn't appear anymore as instaling parse5 also installs typedefininitions for it

edit:
it looks that its problem with my tsconfig it was missing "skipLibCheck": true, so sorry about that this issue probably can be closed (alternative is moving @types/parse5 to dependencies)

from gettext-extractor.

No worries 😉

I'll consider moving it to dependencies. I didn't really want to install any packages that aren't absolutely necessary but maybe it would be a good idea...

from gettext-extractor.