Comments (11)
You are right. There is no reason for this function to not work with
float arrays.
from mahotas.
I think the same issue affects cwatershed
(my goal right now is to simplify the "distance and watershed" example to avoid having to use stretch
, which has issues when some distances are much larger than the relevant ones and thus cause the actually relevant distances to be squeezed into a single value -- yes, this can obviously be fixed by clipping the distances to a maximal relevant value, but if everything handled floats this would be a non-issue from the beginning).
from mahotas.
Yes, you are right on watershed again. The implementation currently has
integer hardcoded, but there is no reason to do it like that.
Adapting the code is actually fairly trivial. Are you available for
testing it?
from mahotas.
Not until the end of the month, but after that, yes.
from mahotas.
Hi, any news on that topic? I can help with testing now.
from mahotas.
Thanks for the ping. regmax/min now should work for FP images. Watershed is work-in-progress.
from mahotas.
I now added support for watershed too. I did some minimal (smoke) testing [included in unit tests], but I'd appreciate it if you gave it a thorough testing run.
from mahotas.
I looked at the current tests and the best I can think of is to change test_watershed and test_mix_types to also try float entries. Anything else you would suggest?
I also tried it on one of my actual programs and it seems to work fine, but that can hardly be turned into a unit test.
from mahotas.
If it seems to be working for your data, that's OK. If you do find any issue, just open a report. Thanks.
from mahotas.
Actually, the following seemingly reasonable patch to test_watershed
leads to some failing tests. I haven't investigated further, though.
@@ -24,7 +24,7 @@ def test_watershed():
[0,0,0,0],
])
def cast_test(M,S,dtype):
- M = M.astype(dtype)
+ M = M.astype(dtype if issubclass(dtype, (np.integer, int)) else int)
S = S.astype(dtype)
W = mahotas.cwatershed(2-S,M)
assert sys.getrefcount(W) == 2
@@ -35,7 +35,8 @@ def test_watershed():
[2, 2, 2, 2],
[2, 2, 2, 2],
[2, 2, 2, 2]]))
- for d in [np.uint8, np.int8, np.uint16, np.int16, np.int32, np.uint32,int]:
+ for d in [np.uint8, np.int8, np.uint16, np.int16, np.int32, np.uint32, int,
+ np.float16, np.float32, np.float64, np.float128, float]:
yield cast_test, M, S, d
from mahotas.
The markers
argument should always be integer, but the other test is good and I can reproduce it.
from mahotas.
Related Issues (20)
- Proposing a PR to fix a few small typos
- "Input data has unexpected types" - Bug in mahotas.features.lbp.lbp HOT 1
- Publish wheels for python 3.9 HOT 3
- Error in using the Zernike moments. HOT 6
- Add support to release linux aarch64 wheels
- freeimage tests fail due to use of `tmpdir` HOT 1
- Latest version (1.4.12) is without a source distribution HOT 2
- make fill_polygon accept floats HOT 2
- Pip install error HOT 3
- Make dilate and erode accept floats HOT 5
- Python 3.11 wheels HOT 1
- Is it possible to *not* release the GIL? HOT 4
- RuntimeError: module compiled against API version 0x10 but this version of numpy is 0xf HOT 1
- Online documentation outdated HOT 2
- Mahotas.features.haralick takes too long to compute when distance increases is greater than 100.
- Texture Correlation Calculation HOT 1
- Segmentation fault: test_negative_values_haralick crashes Python on linux-aarch64 HOT 1
- Failure on pip install mahotas HOT 15
- How to return classification? After training the model HOT 2
- `std::random_shuffle` deprecated in C++14 and removed in C++17 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mahotas.