Code Monkey home page Code Monkey logo

Comments (4)

patrickmuhi avatar patrickmuhi commented on June 22, 2024

Looking through your sources, you imagine that a video from youtube will have an 'embed' element which is wrong, these days all youtube videos are enclosed in an iframe,

i found a way to solve this, maybe i might do a PR,

It's just a single line i edited anyway

from readability.

patrickmuhi avatar patrickmuhi commented on June 22, 2024

#99

from readability.

haroldtreen avatar haroldtreen commented on June 22, 2024

Where are you expecting to see the iframe? I don't have context on why the iframes are removed, but I don't believe that the extension searches within iframes for potential content.

Is this just so that they are within jsdom when the extraction completes? I'm not following the use case for this.

from readability.

patrickmuhi avatar patrickmuhi commented on June 22, 2024

@haroldtreen i wanted to extract youtube videos, but most are iframes. You remove iframes, some have youtube videos. in #99 i removed the line that cleans out iframes, will play with it later and valid if an iframe has a video. closing this now.

from readability.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.