Comments (4)
Looking through your sources, you imagine that a video from youtube will have an 'embed' element which is wrong, these days all youtube videos are enclosed in an iframe,
i found a way to solve this, maybe i might do a PR,
It's just a single line i edited anyway
from readability.
from readability.
Where are you expecting to see the iframe? I don't have context on why the iframes are removed, but I don't believe that the extension searches within iframes for potential content.
Is this just so that they are within jsdom when the extraction completes? I'm not following the use case for this.
from readability.
@haroldtreen i wanted to extract youtube videos, but most are iframes. You remove iframes, some have youtube videos. in #99 i removed the line that cleans out iframes, will play with it later and valid if an iframe has a video. closing this now.
from readability.
Related Issues (20)
- article.content only contains a part of the content HOT 2
- why returning binary result? HOT 3
- About jsdom usage
- Question: can the library tell me if the website is a good candidate for extraction? HOT 1
- Call Stack Size Exceeded HOT 4
- [security] npms.io thinks the node-readability is insecure? HOT 1
- https issue
- A weird problem: get 404 page by read method
- Error on require
- Vulnerability in dependencies
- 有打包好的js,CDN方式引入的吗 HOT 1
- Readability Core
- Is there a way to have an option to not escape the contents of <textarea>?
- A web-compatible distributable version?
- 标签属性去除不干净
- Synchronous functionality when passing raw html HOT 2
- Consider remove or compress example images from repo? HOT 4
- Why is lightbox in unlikelyCandidatesRe? HOT 3
- textBody returns only the first content element
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from readability.