redirect_back not work as expected as previous_url about lucky HOT 4 OPEN

Is there any info that needs to be update for clarify?

from lucky.

redirect_back is working as expected. When you went to the edit page from the universities index page, the index was the referrer. But when you submit the form, the referrer is the get request for the edit page which is why it sent you back to it. I would recommend passing the url you want to send them back to as a field in the form if that's what you really want. Otherwise, just always redirect to the index

(Of course, I could be wrong).

from lucky.

This issue has been going on for some time, please let me try to reexplain it with more details.

1. When i visit GET /universities/788/edit from the index page ("http://127.0.0.1:3000/universities"), I add some pp! code in the edit page, as following, the output of context.request.headers["Referer"] and previous_url(Universities::Index) in the form page both correct.

both output in the edit form page

web | context.request.headers["Referer"] # => "http://127.0.0.1:3000/universities"
web | previous_url(Universities::Index) # => "http://127.0.0.1:3000/universities"

2. Let me submit the form

Then submit the form use PUT action, as you said in the reply, action print referer as edit page correctly

output in the action

request.headers["Referer"] # => "http://127.0.0.1:3000/universities/788/edit"

3. We save the form successfully, the code is jump into the following redirect_back as following.

      if operation.saved?
        pp! "Print in update action", request.headers["Referer"]
        flash.success = "修改成功"
>        redirect_back fallback: Index, allow_external: true
      else
        flash.failure = "出错了"
        html EditPage, operation: operation, university: updated_university
      end

4. Then the following output is the pp! in the edit page. (redirect_back redirect page back to original edit page in this case)

web          | GET /universities/812/edit
web          |  ▸ Handled by Universities::Edit
web          | "Print in form" # => "Print in form"
web          | context.request.headers["Referer"] # => "http://127.0.0.1:3000/universities/812/edit"
web          | previous_url(Universities::Index) # => "/universities"
web          |  ▸ Rendered Universities::EditPage
web          |  ▸ Sent 200 OK (3.11ms)

5. so, the issue is, why previous_url(Universities::Index) return "/universities"? as the expected behavior said in your reply of redirect_back, previous_url should return edit page, right?

@matthewmcgarvey Thanks.

from lucky.

My guess is maybe a bug in previous_url ?

I'm not sure what this line is doing

from lucky.