Code Monkey home page Code Monkey logo

Comments (7)

fferflo avatar fferflo commented on July 28, 2024 1

Hey Phil, you're totally good, I was just wondering if I had missed a bug somewhere and thought I'd share my findings here.

I love that you're finding it helpful!

from ring-attention-pytorch.

lucidrains avatar lucidrains commented on July 28, 2024 1

@fferflo dinner's on me if you ever come to SF! 🤣 i can invite Alex too (he's in south san fran)

from ring-attention-pytorch.

fferflo avatar fferflo commented on July 28, 2024 1

That would be really awesome, although it's quite the trip from Germany so I'm not sure when I'll be able to cash in on the dinner 😄

from ring-attention-pytorch.

lucidrains avatar lucidrains commented on July 28, 2024

@kyegomez ah yea, maybe einx is still a bit new

reverted back to einops for now

from ring-attention-pytorch.

fferflo avatar fferflo commented on July 28, 2024

I might overlook something, but it's possible the error stems from passing heads=True rather than an int to RingAttention in https://github.com/kyegomez/Gemini/blob/main/gemini_torch/long_gemini.py#L65 and might appear with einops also.

from ring-attention-pytorch.

lucidrains avatar lucidrains commented on July 28, 2024

@fferflo oh hey Florian! yeah this is my bad, should have checked instead of assuming

let me revert back to einx, been using it in a couple projects now and so far so good!

from ring-attention-pytorch.

kyegomez avatar kyegomez commented on July 28, 2024

@lucidrains @fferflo no invite 😔

from ring-attention-pytorch.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.