[Bug]: Type Compatibility Issue with CookieAttributes and AstroCookieSetOptions about lucia HOT 5 CLOSED

Can you please share the actual code that's causing the warning?

from lucia.

cross posting from the discord:

Line:

• context.cookies.set(sessionCookie.name, sessionCookie.value, sessionCookie.attributes);

In:

• /pages/api/logout.ts
• /pages/api/login.ts
• /pages/api/signup.ts
• /middleware.ts * 2

from lucia.

Main issue here seems to be that Astro's cookies.set doesn't merely accept cookie attributes but select options from the cookie package's parse function. 7 out of 8 of these are actually just cookie attributes (what Oslo's type maps to) so it mostly works but Astro picks an additional type, the encode option which is a function that the cookie package accepts for alternative encoding of the value.

I'm not sure there's a sensible way for Oslo to add this to its types, nor am I exactly sure why it is complaining, as what Oslo's cookie type contains is a completely valid subset of what Astros function takes for options. But it might be that it's mad because it doesn't have the possibility to even get its encode option based on Oslo's type.

It might be possible to do something like this, essentially telling TS we leave the ability to pass an encode option open:

cookies.set(sessionCookie.name, sessionCookie.value, { ...sessionCookie.attributes });

Not in a position to test it myself tho, but at a glance I think it might work.

from lucia.

I can't seem to reproduce the issue.

Property 'encode' is missing in type 'CookieAttributes' but required in type 'AstroCookieSetOptions'.

This error doesn't make sense since encode() is optional in AstroCookieSetOptions. Have you tried updating to the latest version of Astro?

from lucia.

This seems to be an issue with an older version of Astro. Updating to latest should fix the issue

from lucia.