Change action used to activate plugins? about wp-browser HOT 4 CLOSED

Hooking at muplugins_loaded is a fairly common practice and one honoring WordPress real loading sequence. To point out some authoritative test code: posts-to-posts bootstrap file.
Furthermore the standard WordPress component loading flow loads plugins right after mu-plugins as can be seen in the wp-settings.php file.
Delaying that call would mean creating artificial conditions for the plugin existing in the test environment only.
There is, though, something happening between the muplugins_loaded and the plugins_loaded hook and it might be worth exploring the possibility to have the plugins loaded in a similar fashion

tests_add_filter( 'plugins_loaded', [ $this, `activatePlugins` ], PHP_INT_MIN );

aka "very very early in the hook".

from wp-browser.

Just to clarify, my suggestion wasn't to change when plugins are loaded - it was to change the hook on which they are activated.

I'd also agree wp may not be the best action either (though it works) - wp_loaded is probably better. Here's my take on the expected sequence of events when a plugin is activated:

• wp-load.php bootstraps WordPress
• wp-config.php is included by wp-load.php
• wp-settings.php is included by wp-config.php
  • muplugins_loaded fires
  • plugins_loaded fires
  • Various key objects are now instantiated (including the $wp_rewrite global)
  • wp_loaded fires (at this point, we're right at the end of wp-settings.php)
• The next thing we are interested in is the call to activate_plugin(...) which is responsible for firing the activate_{plugin} hook

So it's not unreasonable for a plugin to want to interact with things like $wp_rewrite when the activation hook runs - directly or indirectly (ie, by registering a post type). All I'm really saying is, yep let's load the plugins as we're currently doing (or on plugins_loaded) - but activation ought to move forward, as it would if we weren't in a test environment.

Does that make more sense?

from wp-browser.

It makes total sense and I think you are right.
I'm looking into it and will address this shortly, thanks for pointing it out.

from wp-browser.

I've updated the code to move the plugin activation to the wp_install hook. This should take care of the plugin activation issue and give activating plugins the environment those need.

from wp-browser.