add option to disable telemetry about caddy-docker-proxy HOT 12 CLOSED

I was thinking about adding a PR for this. What would you expect the resulting Docker images to be named? i.e. caddy-docker-proxy:alpine-no-telemetry? Or would you rather move the default to no telemetry and instead caddy-docker-proxy:alpine is with telemetry disabled and caddy-docker-proxy:alpine-telemetry is what is currently built?

from caddy-docker-proxy.

Caddy v2 has no telemetry.

from caddy-docker-proxy.

We don't affect caddy cli flags.
I think you can just follow caddy documentation on how to disable it.
https://caddyserver.com/docs/telemetry

from caddy-docker-proxy.

https://caddyserver.com/docs/cli#disabled-metrics

from caddy-docker-proxy.

The only way to completely disable telemetry is at compile time by setting the flag enableTelemetry to false. Would it be possible to generate a docker image with this disabled?

from caddy-docker-proxy.

Yes, I will work on it

from caddy-docker-proxy.

Or maybe just disable it for caddy-docker-proxy based on this comment: caddyserver/caddy#2355 (comment)?

from caddy-docker-proxy.

I think we should go a bit more towards adding a cli option + env variable to disable telemetry instead of doubling the number of tags we have in docker image.

from caddy-docker-proxy.

I'm still not sure if it should be enabled or disabled by default.
@mholt Maybe you can provide some feedback about telemetry feature, will it be discontinued?

from caddy-docker-proxy.

We don't have any plans to discontinue telemetry. We might change its defaults in Caddy 2, but Caddy 2 will have a monitoring platform as well so we will have to see how that changes things!

from caddy-docker-proxy.

I know this issue was closed a while ago, but it's still coming up as a to google result.

As a workaround for docker, the telemetry url can be effectively blocked with an extra host argument of --add-host telemetry.caddyserver.com:127.0.0.1 or for docker-compose:

extra_hosts:
 - "telemetry.caddyserver.com:127.0.0.1"

from caddy-docker-proxy.

Ok sorry my mistake. I used image: 'abiosoft/caddy:latest' and assumed it was v2.

from caddy-docker-proxy.