Plugin is always adding proxy directive about caddy-docker-proxy HOT 4 CLOSED

Hey Jtyr. The idea of the caddy.address directive was to be a shortcut to autogenerated proxies. But because caddy.targetport label was required, the proxy wasn't generated on your setup. I didn't realize caddy.adress could be used alone. What I would suggest is to use just caddy label when you don't want it to generate a proxy. Like: caddy_1=example.com caddy_1.redir=... Tomorrow I will think how I can avoid this breaking change on next release. Currently the breaking change is on ci tags only. Thanks for reporting this Em 12 de set de 2018 7:12 PM, Jiri Tyr <[email protected]> escreveu: After the recent changes, the plugin is always adding the proxy directive regardless if the directive has any proxy related data defined. Before we could use: labels: caddy_1.address: http://example.lan:8080 caddy_1.redir: https://disney.example.lan:8443{uri} caddy_2.address: https://example.lan:8443 caddy_2.tls: self_signed caddy_2.targetport: 80 caddy_2.proxy.keepalive: 0 which generated: http://disney.example.lan:8080 { redir https://disney.example.lan:8443{uri} } https://disney.example.lan:8443 { import myTlsDefaults proxy / myservice:80 { keepalive 0 } } but now it generates: http://disney.example.lan:8080 { proxy / myservice:80 redir https://disney.example.lan:8443{uri} } https://disney.example.lan:8443 { import myTlsDefaults proxy / myservice:80 { keepalive 0 } } — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#67>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACKcfEcB6EzH2RDSvjipGoUUpX9h6hhwks5uaUCQgaJpZM4Wl0P0>.