Code Monkey home page Code Monkey logo

Comments (6)

lucaslorentz avatar lucaslorentz commented on July 22, 2024

Thanks for reviewing @ibnesayeed .

We're using the function NewEnvClient from docker. It creates a docker client using Environment variables configuration falling back to default values.

I think you can configure how it should connect to the docker api by setting environment variables.

// Use DOCKER_HOST to set the url to the docker server.
// Use DOCKER_API_VERSION to set the version of the API to reach, leave empty for latest.
// Use DOCKER_CERT_PATH to load the tls certificates from.
// Use DOCKER_TLS_VERIFY to enable or disable TLS verification, off by default.

More info here: https://github.com/docker/engine-api/blob/master/client/client.go#L42

from caddy-docker-proxy.

ibnesayeed avatar ibnesayeed commented on July 22, 2024

Yes, from my casual scan of your code, I did not see any place where you were opening the socket file yourself, so I knew it was offloaded to Docker packages. This means we get this functionality for free. We just need to test it and document accordingly.

from caddy-docker-proxy.

lucaslorentz avatar lucaslorentz commented on July 22, 2024

Added that information to README file.

from caddy-docker-proxy.

ibnesayeed avatar ibnesayeed commented on July 22, 2024

@lucaslorentz, I think where we are documenting the DOCKER_HOST, we need to explicitly mention that by default it will connect to /var/run/docker.sock socket file.

from caddy-docker-proxy.

lucaslorentz avatar lucaslorentz commented on July 22, 2024

DOCKER_HOST default value varies per platform /var/run/docker.sock
Windows: "npipe:////./pipe/docker_engine"
Unix: "unix:///var/run/docker.sock"

I will add it to README.

from caddy-docker-proxy.

lucaslorentz avatar lucaslorentz commented on July 22, 2024

Done

from caddy-docker-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.