Code Monkey home page Code Monkey logo

Comments (9)

lucacasonato avatar lucacasonato commented on July 3, 2024 2

I dont think that is the way. I think that is the legacy way for the 'builds' property - the new 'functions' property does not support config I think. The Node.js runtime uses engines.node in package.json and Go is just pinned to latest 1.x. We can probably pin to latest and let user specify a specific version via the env var DENO_VERSION - that should then 1:1 map to deno-lambda version. That env var can then be specified using build.env in now.json.

from now-deno.

stephengfriend avatar stephengfriend commented on July 3, 2024 2

That's totally fair. I wrote the tests to be compatible with it and I'm giving it a run-through, as well.

from now-deno.

hayd avatar hayd commented on July 3, 2024 1

denoland/deno-lambda#20 is closed now: releases will match the deno version.

from now-deno.

stephengfriend avatar stephengfriend commented on July 3, 2024 1

Hey, thanks for checking in. I almost forgot about it. Yes, I'll take a look today.

from now-deno.

hayd avatar hayd commented on July 3, 2024

Should this be config.denoVersion? Is that the way to do this?

from now-deno.

lucacasonato avatar lucacasonato commented on July 3, 2024

I'll wait for denoland/deno-lambda#20 to be done before implementing this.

from now-deno.

stephengfriend avatar stephengfriend commented on July 3, 2024

Mind if I grab this? I was working on delivering a PR for now dev but noticed it landed a little bit ago.

from now-deno.

lucacasonato avatar lucacasonato commented on July 3, 2024

Sure. Just be aware I won't merge it until denoland/deno-lambda#20 is closed.

from now-deno.

lucacasonato avatar lucacasonato commented on July 3, 2024

@stephengfriend Do you still want to take this? If you don't want to anymore, I'll take it.

from now-deno.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.