Code Monkey home page Code Monkey logo

Comments (1)

MarkTiedemann avatar MarkTiedemann commented on May 13, 2024

I added a console.log.

The unzip code is trying to write to %localappdata%\deno\deno_puppeteer\firefox\win64-90.0a1\firefox\uninstall\helper.exe.

%localappdata%\deno\deno_puppeteer\firefox\ exists. The other subdirectories, \win64-90.0a1\firefox\uninstall\ don't.

Seems like the code at https://github.com/lucacasonato/deno-puppeteer/blob/9.0.0/vendor/puppeteer-core/vendor/zip/mod.ts#L192-L205 is buggy.

EDIT: As the comment there // hopefully the directory is prior to any files inside it! points out, this is a case where the directory is not prior to the files inside of it.

Will send a PR which adds a check that the base dir exists before writing a file to it.

from deno-puppeteer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.