Tests are failing about php-curve25519 HOT 6 CLOSED

Thanks, I know about this.

When I decided I didn't care about a 32-bit implementation I updated the code but ignored the tests (the tests were kind of pointless anyway for the most part). I'll find some good vectors to test against one day, but these projects are not a priority for me right now.

from php-curve25519.

@lt It sounds like you're not actively maintaining this implementation. How would you generally feel about having this in phpseclib instead? https://github.com/phpseclib/phpseclib

from php-curve25519.

Hey @bantu

It's MIT licensed, feel free to do what you want with it :) - I will never make this PHP 4 compatible or revert to the BigInteger library, so you'll have to fork it anyway to match your projects goals, regardless of whether I maintain it.

Also, these tests are pretty bad, I didn't know what to test and couldn't find any reference tests, so when I had a working implementation (before optimising), I just took some known outputs from various functions to make sure optimising didn't break anything.

Add a watch to this repo, and you'll see if I ever update it, and you can copy changes if you feel like it.

from php-curve25519.

I will never make this PHP 4 compatible or revert to the BigInteger library, so you'll have to fork it anyway to match your projects goals, regardless of whether I maintain it.

I think the implementation is perfectly fine. phpseclib 2.0 will require PHP 5.3.3, so it would basically be replacing [] with array()

Add a watch to this repo, and you'll see if I ever update it, and you can copy changes if you feel like it.

This is something I would rather want to avoid. Hence the question.

from php-curve25519.

I didn't realise there was a 2.0 in the works (I guess it's the php5 branch). Perhaps I will take a look and see where I can speed things up :)

from php-curve25519.

Tests are working again, added a new vector from the NaCL lib.

from php-curve25519.