Infinite error loop if user quit Spotify app about spotify-connect-ws HOT 5 CLOSED

Thank you very much for investing your time in this helpful library - works like a charm in my case.

from spotify-connect-ws.

Thanks for the report and contribution @jfbausch!

Just to be sure, you mean that this error occurs when the user quits the playback app, right?

I'm trying to think about the best way to handle that, and I'm not sure that we should be closing the connection, rather than reporting the failure as an error to the client (it may be useful to let the user know that something's gone wrong).

But you're right that we should absolutely be handling that promise rejection in some way. I'll do some testing later on and we'll get this issue sorted!

from spotify-connect-ws.

Just to be sure, you mean that this error occurs when the user quits the playback app, right?

Yeah, exactly - either by quitting the app, closing the browser tab or login out.

Thanks for the quick response. Hit me up, if I can help you with something.

from spotify-connect-ws.

Hey @jfbausch, thanks again for reporting this issue! I had a look into it and noticed a bunch of ways that the error logic could be improved. To fix the issue you directly mentioned, I have started to check the status code returned by Spotify in the 'getPlayerState' method. It seems to return a 202 when there is no active device (and no JSON, which caused the error), so we can do one better than sending a generic error, and instead detect the issue and let the client know what's gone wrong with a more descriptive message.

This change has been pushed to npm as v0.1.0, please let me know if this resolves the issue for you!

from spotify-connect-ws.

Glad to hear it! Please feel free to report any more issues that you encounter, I'll be happy to help. And send a link over if/when you publish your project!

from spotify-connect-ws.